[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Remove experimental MapEffect composable #267

Open
wangela opened this issue Feb 16, 2023 · 4 comments
Open

RFC: Remove experimental MapEffect composable #267

wangela opened this issue Feb 16, 2023 · 4 comments
Labels
needs more info This issue needs more information from the customer to proceed. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wangela
Copy link
Member
wangela commented Feb 16, 2023

If you would like to recommend against this proposal, please comment below or react with 👎 .

MapEffect was added in #140 to expose the underlying GoogleMap Maps SDK object to enable extension and usages such as clustering with the utility library.

With Compose-native clustering being added by #258, we're hoping that MapEffect is no longer needed. Providing direct access to the map is potentially buggy as noted in this comment.

It seems like MapEffect would still be necessary for other Android Maps Utils such as GeoJSON layer (#29) and KML layer (#129).

Please comment below if you have other use cases that would require exposing the map object.
@wangela wangela added needs more info This issue needs more information from the customer to proceed. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Feb 16, 2023
@wangela wangela mentioned this issue Feb 16, 2023
Merged
2 tasks
@Shusshu
Copy link
Shusshu commented Feb 20, 2023

#272

@philip-segerfast
Copy link

#282

@kikoso kikoso added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Jul 10, 2023
@wangela
Copy link
Member Author
wangela commented Aug 11, 2023

Also useful for helping with #293

@br00
Copy link
br00 commented Oct 24, 2023

As others already pointed out removing MapEffect will not make possible to add any Kml or GeoJson layer to a compose map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs more info This issue needs more information from the customer to proceed. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kikoso @Shusshu @br00 @wangela @philip-segerfast