[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Groovy gradle files to Kotlin DSL #273

Open
oas004 opened this issue Feb 20, 2023 · 0 comments
Open

Convert Groovy gradle files to Kotlin DSL #273

oas004 opened this issue Feb 20, 2023 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@oas004
Copy link
Contributor
oas004 commented Feb 20, 2023

Hey!

This is just a suggestion and I wanted to know what you thought about it. Feel free to close it, if it does not make sense.

I noticed that all the gradle files are in Groovy, what do you think about converting it to Kotlin DSL? I saw that the NowInAndroid app and Horologist has this, but for instance Accompanist does not. Is there a reason for not converting? :)

I would be happy to contribute this if it is desirable.

Is your feature request related to a problem? Please describe.
Not related to a problem.

Describe the solution you'd like
If I were going to implement this, I would go through each module and apply the first steps to prepare the groovy scripts for easy migration (https://docs.gradle.org/current/userguide/migrating_from_groovy_to_kotlin_dsl.html#prepare_your_groovy_scripts). Then I would convert the scripts module by module, separating it in each PR respectfully.

Describe alternatives you've considered
Considered not doing it, then feel free to close this.

Additional context
N/A

@oas004 oas004 added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 20, 2023
@kikoso kikoso added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants