[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create lint rules for Maps Compose #218

Open
arriolac opened this issue Oct 31, 2022 · 1 comment
Open

Create lint rules for Maps Compose #218

arriolac opened this issue Oct 31, 2022 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@arriolac
Copy link
Member
arriolac commented Oct 31, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Maps Compose has frequently changing state that should not be read in composition. Example of this are:

  • MarkerPositionState.positon - this changes frequently when a marker is dragged
  • CameraPositionState.position - this changes frequently as the map's camera changes

Describe the solution you'd like
Provide lint rules that give warnings when the state mentioned above is read within composition.

Describe alternatives you've considered
Do nothing.

Additional context
Take a look at https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation-lint/src/test/java/androidx/compose/foundation/lint/LazyLayoutStateReadInCompositionDetectorTest.kt?q=firstVisibleItemIndex&start=21 and https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation-lint/src/main/java/androidx/compose/foundation/lint/LazyLayoutStateReadInCompositionDetector.kt;l=40?q=LazyLayoutStateReadInCom&sq= as an example
@arriolac arriolac added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. labels Oct 31, 2022
@stale
Copy link
stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

@stale stale bot added the stale label Jun 18, 2023
@kikoso kikoso added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. stale labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arriolac @kikoso