[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googlemaps-3.1.0.tar.gz listed on pypi is missing CHANGELOG.md used in setup.py #307

Closed
seahawk1986 opened this issue Aug 28, 2019 · 2 comments
Closed

googlemaps-3.1.0.tar.gz listed on pypi is missing CHANGELOG.md used in setup.py #307

seahawk1986 opened this issue Aug 28, 2019 · 2 comments
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: process A process-related concern. May include testing, release, or the like.

Comments

@seahawk1986
Copy link
seahawk1986 commented Aug 28, 2019 •
edited
Loading

Hello,
https://files.pythonhosted.org/packages/35/45/e04a8c4fbe721e1e2f73319239812fc479d31a0d6bc790b5e44c9e0ea613/googlemaps-3.1.0.tar.gz is missing the file CHANGELOG.md (and several other files) when compared with https://github.com/googlemaps/google-maps-services-python/archive/3.1.0.tar.gz

Since CHANGELOG.md is read by setup.py installing the package from source fails:

Traceback (most recent call last):
  File "setup.py", line 18, in <module>
    with io.open("CHANGELOG.md", encoding="utf8") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'CHANGELOG.md'

I suppose CHANGELOG.md needs to be added to the MANIFEST.in file.
@jpoehnelt
Copy link
Contributor

closed by #308

@jpoehnelt jpoehnelt added priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: process A process-related concern. May include testing, release, or the like. labels Aug 28, 2019
This was referenced Aug 28, 2019
Closed
Merged
Merged
@jpoehnelt
Copy link
Contributor

This should be fixed in googlemaps==3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seahawk1986 @jpoehnelt