[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture server metadata in traces over gRPC #13275

Closed
dbolduc opened this issue Dec 11, 2023 · 0 comments · Fixed by #13278
Closed

Capture server metadata in traces over gRPC #13275

dbolduc opened this issue Dec 11, 2023 · 0 comments · Fixed by #13278
Labels
cpp: opentelemetry type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dbolduc
Copy link
Member
dbolduc commented Dec 11, 2023

A deferred piece of #10489, it would be nice to capture the response headers, trailers like we do when using REST as the transport.

There are testability issues, related to grpc::ClientContext that need to be resolved first.

Semantics

https://opentelemetry.io/docs/specs/semconv/rpc/grpc/

The headers should be captured as: rpc.grpc.response.metadata.<key>.

Additionally, in the case of binary headers (suffixed with -bin), I think we should just capture the bytes as a hex string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cpp: opentelemetry type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(otel): capture gRPC response metadata in traces dbolduc/google-cloud-cpp
1 participant
@dbolduc