[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: rollback when panic occurs in RunInTransaction. #5969

Open
yuki2006 opened this issue May 1, 2022 · 0 comments
Open

datastore: rollback when panic occurs in RunInTransaction. #5969

yuki2006 opened this issue May 1, 2022 · 0 comments
Assignees
@triplequark
Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@yuki2006
Copy link
yuki2006 commented May 1, 2022 •
edited
Loading

Is your functional requirement relevant to the issue? Please describe.

We would like to be rollback in the unlikely event of a panic in a RunInTransaction.

Describe the solution you want.

We want rollback using defer and recover for f(tx).

google-cloud-go/datastore/transaction.go

Line 173 in dd8973b

tx, err := c.newTransaction(ctx, settings)

Describe alternatives you have considered.

none

Additional Context.

none
@yuki2006 yuki2006 added the triage me I really want to be triaged. label May 1, 2022
@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label May 1, 2022
@telpirion telpirion added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels May 2, 2022
@telpirion telpirion mentioned this issue Oct 26, 2022
Closed
@telpirion telpirion assigned triplequark and unassigned telpirion Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@triplequark triplequark

Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datastore): attempt rollback after panic in transaction googleapis/google-cloud-go
3 participants
@yuki2006 @telpirion @triplequark