[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: flaky transaction tag test failure #8590

Closed
olavloite opened this issue Sep 18, 2023 · 5 comments · Fixed by #8712
Closed

spanner: flaky transaction tag test failure #8590

olavloite opened this issue Sep 18, 2023 · 5 comments · Fixed by #8712
Assignees
@rahul2393
Labels
api: spanner Issues related to the Spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Contributor 
=== NAME  TestClient_ReadOnlyTransaction_Tag
    testing.go:1465: race detected during execution of test
--- FAIL: TestClient_ReadOnlyTransaction_Tag (0.04s)
=== CONT  TestClient_PDML_Priority
=== NAME  TestStressSessionPool/TestStressSessionPoolGroup2
    session_test.go:894: TestStressSessionPoolWithCfg2Worker093
    session_test.go:894: TestStressSessionPoolWithCfg2Worker094
    session_test.go:894: TestStressSessionPoolWithCfg2Worker095
    session_test.go:894: TestStressSessionPoolWithCfg2Worker096
=== NAME  TestClient_ReadWriteTransaction_Tag
    testing.go:1465: race detected during execution of test
--- FAIL: TestClient_ReadWriteTransaction_Tag (0.08s)

Source: https://source.cloud.google.com/results/invocations/d3b0eafa-7bda-43b9-987b-2de813e47c96/targets/cloud-devrel%2Fclient-libraries%2Fgo%2Fgoogle-cloud-go%2Fpresubmit%2Flatest-version/log
@olavloite olavloite added the type: process A process-related concern. May include testing, release, or the like. label Sep 18, 2023
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Sep 18, 2023
@rahul2393
Copy link
Contributor
rahul2393 commented Sep 19, 2023 •
edited
Loading

Seems like issue in spannertest package, thanks for pointing it out, will dig more.

@rahul2393 rahul2393 added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Oct 3, 2023
@noahdietz
Copy link
Contributor

I think this issue is now blocking PRs with Kokoro failures: https://source.cloud.google.com/results/invocations/667dd248-c60f-4196-b5b9-9b2e7f294198/targets/cloud-devrel%2Fclient-libraries%2Fgo%2Fgoogle-cloud-go%2Fpresubmit%2Flatest-version/log

@codyoss
Copy link
Member
codyoss commented Oct 12, 2023

If we are prioritizing fixing this issue please skip the test until there is time to fix the issue.

@rahul2393
Copy link
Contributor

Let me create PR to skip the test for now

@rahul2393 rahul2393 mentioned this issue Oct 13, 2023
Merged
@rahul2393
Copy link
Contributor

Found a code block which can cause data race, will reopen if it does not fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the Spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(spanner): fix data race issue in inmemory spanner test runs googleapis/google-cloud-go
5 participants
@olavloite @codyoss @noahdietz @rahul2393 and others