[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: defers are executed at the end of func #10323

Open
egonelbre opened this issue Jun 5, 2024 · 0 comments · May be fixed by #9759
Open

spanner: defers are executed at the end of func #10323

egonelbre opened this issue Jun 5, 2024 · 0 comments · May be fixed by #9759
Assignees
@harshachinta
Labels
api: spanner Issues related to the Spanner API.

Comments

@egonelbre
Copy link
Contributor

Tracking issue for #9759

Related #9784

Currently there are quite a few tests that have a code along the lines of:

for _, test := range testcases {
    client := NewClient(...)
    defer client.Close()

This closing will happen at the end of the function, not at the end of the for loop.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 5, 2024
@egonelbre egonelbre linked a pull request Jun 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(spanner): ensure defers run at the right time in tests egonelbre/google-cloud-go
2 participants
@egonelbre @harshachinta