[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: increase sessions in the pool in batches #1920

Closed
olavloite opened this issue Apr 14, 2020 · 1 comment
Closed

spanner: increase sessions in the pool in batches #1920

olavloite opened this issue Apr 14, 2020 · 1 comment
Assignees
@olavloite
Labels
api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@olavloite
Copy link
Contributor

The session pool should increase the number of sessions in the pool in batches instead of one by one when additional sessions are needed. This reduces the number of CreateSession / BatchCreateSessions that is needed to maintain the pool.
@olavloite olavloite added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: spanner Issues related to the Spanner API. labels Apr 14, 2020
@olavloite olavloite self-assigned this Apr 14, 2020
@olavloite
Copy link
Contributor Author

Benchmarking based on https://code-review.googlesource.com/c/gocloud/+/54690

Method Inc Time (ms)
Benchmark_Client_BurstRead 1 1043.8
Benchmark_Client_BurstRead 10 1033.4
Benchmark_Client_BurstRead 20 1039.3
Benchmark_Client_BurstRead 25 1038.1
Benchmark_Client_BurstRead 30 1028.7
Benchmark_Client_BurstRead 40 1041.3
Benchmark_Client_BurstRead 50 1031.8
Benchmark_Client_BurstRead 100 1039.5
Benchmark_Client_BurstWrite 1 743.6
Benchmark_Client_BurstWrite 10 734.4
Benchmark_Client_BurstWrite 20 757.9
Benchmark_Client_BurstWrite 25 856.6
Benchmark_Client_BurstWrite 30 726.3
Benchmark_Client_BurstWrite 40 729.9
Benchmark_Client_BurstWrite 50 796.1
Benchmark_Client_BurstWrite 100 715.9
Benchmark_Client_BurstReadAndWrite 1 972.2
Benchmark_Client_BurstReadAndWrite 10 959.1
Benchmark_Client_BurstReadAndWrite 20 930.3
Benchmark_Client_BurstReadAndWrite 25 910.4
Benchmark_Client_BurstReadAndWrite 30 962.9
Benchmark_Client_BurstReadAndWrite 40 966.0
Benchmark_Client_BurstReadAndWrite 50 989.7
Benchmark_Client_BurstReadAndWrite 100 988.3
Benchmark_Client_SteadyIncrease 1 13089.5
Benchmark_Client_SteadyIncrease 10 6005.7
Benchmark_Client_SteadyIncrease 20 5697.5
Benchmark_Client_SteadyIncrease 25 5545.9
Benchmark_Client_SteadyIncrease 30 5487.6
Benchmark_Client_SteadyIncrease 40 5371.7
Benchmark_Client_SteadyIncrease 50 5411.3
Benchmark_Client_SteadyIncrease 100 5365.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olavloite