[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspecting HttpResponse content in BackOffRequired results in IOException later #1403

Open
pingw33n opened this issue Jun 29, 2021 · 0 comments
Open

Inspecting HttpResponse content in BackOffRequired results in IOException later #1403

pingw33n opened this issue Jun 29, 2021 · 0 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@pingw33n
Copy link

When implementing retries for Compute client one needs to read and parse HttpResponse as JSON in order to find rateLimitExceeded error in details (we could rely on the status code but unfortunately it's a generic 403 Forbidden in this case). Later when the library attempts to read the response again to throw GoogleJsonResponseException it won't be able to fill details field because the HTTP content has been already read (it also printStackTraces an IOException) .

private HttpBackOffUnsuccessfulResponseHandler createRetryHandler() {
            BackOff backOff = new ExponentialBackOff.Builder()
                .setInitialIntervalMillis(1000)
                .setMaxIntervalMillis(5000)
                .setMaxElapsedTimeMillis(60_000)
                .build();
            HttpBackOffUnsuccessfulResponseHandler retryHandler = new HttpBackOffUnsuccessfulResponseHandler(backOff) {
                @Override
                public boolean handleResponse(HttpRequest request, HttpResponse response, boolean supportsRetry)
                    throws IOException {

                    return httpCredentialsAdapter.handleResponse(request, response, supportsRetry) ||
                        super.handleResponse(request, response, supportsRetry);
                }
            };
            retryHandler.setBackOffRequired(resp -> {
                GoogleJsonResponseException exc = GoogleJsonResponseException.from(JacksonFactory.getDefaultInstance(),
                                                                                   resp);
                return
                    exc.getDetails().getErrors().stream().anyMatch(err -> "rateLimitExceeded".equals(err.getReason()));
            });
            return retryHandler;
        }
java.io.IOException: Stream closed
	at java.base/java.util.zip.GZIPInputStream.ensureOpen(GZIPInputStream.java:63)
	at java.base/java.util.zip.GZIPInputStream.read(GZIPInputStream.java:114)
	at org.apache.http.client.entity.LazyDecompressingInputStream.read(LazyDecompressingInputStream.java:70)
	at com.fasterxml.jackson.core.json.ByteSourceJsonBootstrapper.ensureLoaded(ByteSourceJsonBootstrapper.java:539)
	at com.fasterxml.jackson.core.json.ByteSourceJsonBootstrapper.detectEncoding(ByteSourceJsonBootstrapper.java:133)
	at com.fasterxml.jackson.core.json.ByteSourceJsonBootstrapper.constructParser(ByteSourceJsonBootstrapper.java:256)
	at com.fasterxml.jackson.core.JsonFactory._createParser(JsonFactory.java:1656)
	at com.fasterxml.jackson.core.JsonFactory.createParser(JsonFactory.java:1085)
	at com.fasterxml.jackson.core.JsonFactory.createJsonParser(JsonFactory.java:1466)
	at com.google.api.client.json.jackson2.JacksonFactory.createJsonParser(JacksonFactory.java:85)
	at com.google.api.client.googleapis.json.GoogleJsonResponseException.from(GoogleJsonResponseException.java:102)
	at com.google.api.client.googleapis.services.json.AbstractGoogleJsonClientRequest.newExceptionOnError(AbstractGoogleJsonClientRequest.java:118)
	at com.google.api.client.googleapis.services.json.AbstractGoogleJsonClientRequest.newExceptionOnError(AbstractGoogleJsonClientRequest.java:37)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest$1.interceptResponse(AbstractGoogleClientRequest.java:428)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1108)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:514)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:455)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.execute(AbstractGoogleClientRequest.java:565)
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jun 30, 2021
@Neenu1995 Neenu1995 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jul 7, 2021
@klya klya mentioned this issue Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pingw33n @Neenu1995 @yoshi-automation