[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadocs for HttpRequestFactory use deprecated HttpRequest.headers field #22

Closed
wonderfly opened this issue Jan 9, 2015 · 4 comments
Closed
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wonderfly
Copy link
Contributor

From yan...@google.com on August 15, 2011 08:27:32

Version of google-http-java-client (e.g. 1.5.0-beta)? 1.5.0-beta Java environment (e.g. Java 6, Android 2.3, App Engine 1.4.3)? All Describe the problem. JavaDocs for HttpRequestFactory in 1.5.0 ( http://javadoc.google-http-java-client.googlecode.com/hg/1.5.0-beta/com/google/api/client/http/HttpRequestFactory.html ) reference the now-deprecated HttpRequest.headers field in the example code:

public static HttpRequestFactory createRequestFactory(HttpTransport transport) {
return transport.createRequestFactory(new HttpRequestInitializer() {
public void handle(HttpRequest request) {
request.headers.authorization = "...";
}
});
} How would you expect it to be fixed? Change the example to:

request.getHeaders().authorization = "...";

Thanks to darkfoxp...@gmail.com for reporting!

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=22

@wonderfly wonderfly added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. imported priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on August 15, 2011 08:32:24

http://codereview.appspot.com/4907043/

Status: Started
Labels: -Milestone-Version1.6.0 Milestone-Version1.5.1

@wonderfly
Copy link
Contributor Author

From yan...@google.com on August 16, 2011 07:48:59

Labels: Component-HTTP

@wonderfly
Copy link
Contributor Author

From yan...@google.com on August 18, 2011 11:24:05

Status: Fixed

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on October 21, 2011 12:25:47

Labels: -Milestone-Version1.5.1 Milestone-Version1.5.3

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants