[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not taking care of "Maximum number of field transformations" in BulkWriter #1724

Open
yaquawa opened this issue May 13, 2022 · 6 comments
Open

Not taking care of "Maximum number of field transformations" in BulkWriter #1724

yaquawa opened this issue May 13, 2022 · 6 comments
Assignees
@dconeybe
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@yaquawa
Copy link
yaquawa commented May 13, 2022 •
edited
Loading

Hi there

According to the doc
https://firebase.google.com/docs/firestore/quotas#writes_and_transactions

Maximum number of field transformations that can be performed on a single document in a Commit operation or in a transaction : 500

I couldn't find any code handling this limit in the BulkWriter.
Is this a bug or intended?
@yaquawa yaquawa added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 13, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label May 13, 2022
@dconeybe dconeybe self-assigned this May 17, 2022
@dconeybe
Copy link
Contributor

I'm not sure I fully understand your question. What is the "bug" you are referring to? Perhaps you could pose your question with "steps to reproduce", the "expected results" and "actual results". Thank you.

@yaquawa
Copy link
Author
yaquawa commented May 18, 2022

Hi @dconeybe
will this help?
https://stackoverflow.com/questions/70764076/what-is-field-transformations-in-firestore

@dconeybe
Copy link
Contributor

I see. So, are you asking for details about what constitutes a "transformation"? Or are you asking for BulkWriter to be modified to enforce this limit?

@yaquawa
Copy link
Author
yaquawa commented May 19, 2022

Thanks @dconeybe , I'm asking for BulkWriter to be modified to enforce this limit.

@dconeybe
Copy link
Contributor

Ok thank you for the clarification. This is likely something that we could add in the future. Unfortunately, we don't have the bandwidth to work on it any time soon. I've added this issue to our product backlog and we will update this issue if/when we have an update. Thank you for taking the time to make this suggestion. It is a good one.

@yaquawa
Copy link
Author
yaquawa commented May 19, 2022

Thanks @dconeybe 🥳🥳🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconeybe dconeybe

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaquawa @dconeybe