[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): update lighthouse-mocha-example repo and description #9158

Merged
merged 3 commits into from
Jun 12, 2019

Conversation

rishichawda
Copy link
Contributor

Summary

Older example with mocha doesn't work with current lighthouse version (older example is based on v1). This is the updated example repository link with a working example of lighthouse tests with mocha and chai.

Is this a bugfix, feature, refactoring, build related change, etc?

This is a documentation related change.

Describe the need for this change

Older example doesn't work since it is based on an older version of lighthouse and is no longer maintained.

Related Issues/PRs

None.

Older example with mocha doesn't work with current lighthouse version ( older example is based on v1 ). This is the updated example repository link with a working example of lighthouse tests with mocha and chai.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rishichawda
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 9, 2019
readme.md Outdated Show resolved Hide resolved
Co-Authored-By: cjamcl <cjamcl@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rishichawda
Copy link
Contributor Author

@hoten looks like there's some issue with CLA on your account after I accepted the commit suggestion that you added.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Copy link
Member
@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny changed the title chore(readme): update mocha test repository docs(readme): update lighthouse-mocha-example description Jun 10, 2019
@brendankenny brendankenny changed the title docs(readme): update lighthouse-mocha-example description docs(readme): update lighthouse-mocha-example repo and description Jun 10, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@GoogleChrome GoogleChrome deleted a comment from googlebot Jun 10, 2019
Copy link
Member
@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the original hasn't been updated since 2016, but it is a little weird to replace it with a completely different project (though with the same goal) with the same name? Maybe that's ok, though.

cc @justinribeiro if you have an opinion

@justinribeiro
Copy link
Contributor

Yeah, I've been meaning to update the older mocha example to be closer inline with my more robust Jest example (https://github.com/justinribeiro/lighthouse-jest-example).

I'm fine with replacing it, though the name thing might throw people (that example and my old one aren't exactly the same concept-wise, but probably splitting hairs).

@rishichawda
Copy link
Contributor Author
rishichawda commented Jun 10, 2019

@brendankenny @justinribeiro I have no issue with renaming it to something different. Just kept as it is since the name felt relevant to what is in the repository.

Edit: Would like suggestions so I'll update it to whatever seems fit.

Copy link
Collaborator
@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinribeiro has the shiny new jest one in there now so this update LGTM :)

Copy link
Member
@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, SG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants