docs(readme): related project: lighthouse-persist #9161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhenson
commented
Jun 9, 2019
readme.md
Outdated
| @@ -306,6 +306,7 @@ This section details services that have integrated Lighthouse data. If you're wo | |||
| ## Related Projects | |||
| Other awesome open source projects that use Lighthouse. | |||
|
|
|||
| * **[@foo-software/lighthouse-persist](https://github.com/foo-software/lighthouse-persist)** - Run Lighthouse and upload HTML reports to an AWS S3 account. | |||
There was a problem hiding this comment.
Using the scoped package name as it appears on NPM since theoretically another package could be introduced with the same name. Please let me know if you think it should simply be lighthouse-persist and I’ll change it.
There was a problem hiding this comment.
Yeah I would just put it as lighthouse-persist and then move it in-between lighthouse-mocha-example and lighthouse4u.
Does it make sense to call it an S3 account? Afaik it is an AWS account with S3 Buckets, not really an S3 account?
* **[lighthouse-persist](https://github.com/foo-software/lighthouse-persist)** - Run Lighthouse and upload HTML reports to AWS S3 buckets.There was a problem hiding this comment.
Thanks @exterkamp - good point. Updated in fe554f4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
lighthouse-persistto the "Related Projects" section.lighthouse-persistis an open-source project that runs Lighthouse, provides result data and uploads an HTML report to a user's AWS S3 account.