i18n: add es-419 #9171
i18n: add es-419 #9171
Conversation
|
I've never added a new locale! Didn't know to add it to the |
Is there a way to edit my LGTM to make it look like I didn't forget that too? 😆 |
| @@ -40,6 +40,7 @@ const locales = { | |||
| 'el': require('./locales/el.json'), | |||
| 'en-XA': require('./locales/en-XA.json'), // psuedolocalization | |||
| 'es': require('./locales/es.json'), | |||
| 'es-419': require('./locales/es-419.json'), | |||
There was a problem hiding this comment.
much like en-gb, it appears we have to account for the parent/child locales ourselves. Why?? I have no idea.
But here's the list of es-419 child locales: es-AR, es-BO, es-BR, es-BZ, es-CL, es-CO, es-CR, es-CU, es-DO, es-EC, es-GT, es-HN, es-MX, es-NI, es-PA, es-PE, es-PR, es-PY, es-SV, es-US, es-UY, es-VE
Source in the CLDR: https://raw.githubusercontent.com/unicode-cldr/cldr-core/master/supplemental/parentLocales.json
( And tc39/ecma402#87 isn't a thing yet.)
There was a problem hiding this comment.
I know this because I started writing this patch yesterday, before I saw your PR.
But where I went is a dark dark place.... (syntax-wise, at least)
@@ -14,6 +14,9 @@
/** @typedef {Record<string, {message: string}>} LocaleMessages */
+const es419 = require('./locales/es-419.json');
+const es419locales = 'es-AR, es-BO, es-BR, es-BZ, es-CL, es-CO, es-CR, es-CU, es-DO, es-EC, es-GT, es-HN, es-MX, es-NI, es-PA, es-PE, es-PR, es-PY, es-SV, es-US, es-UY, es-VE';
+
// The keys within this const must exactly match the LH.Locale type in externs.d.ts
/** @type {Record<LH.Locale, LocaleMessages>} */
const locales = {
@@ -28,6 +31,9 @@ const locales = {
'en-ZA': require('./locales/en-GB.json'), // Alias of 'en-GB'
'en-IN': require('./locales/en-GB.json'), // Alias of 'en-GB'
+ // https://raw.githubusercontent.com/unicode-cldr/cldr-core/master/supplemental/parentLocales.json
+ ...Object.fromEntries(es419locales.split(', ').map(locale => [locale, es419])),
+
// All locales from here have a messages file, though we allow fallback to the base locale when the files are identical
'ar-XB': require('./locales/ar-XB.json'), // psuedolocalization
'ar': require('./locales/ar.json'),
🤢
There was a problem hiding this comment.
no fromEntries yet (Node 10)
There was a problem hiding this comment.
yah fromEntries ended up being a pain in the ass. Node 10 and TSC both being real cranky about it. Not worth it.
There was a problem hiding this comment.
TL;DR fancy js is fancy, but fancy regex replacements is also fancy, and much easier.
I don't know what we need for i18n these days :)
|
Tagging as part of: #7238 |
Summary
import
es-419and aptcorrection.