You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary
Revive locally generating en-XA! Since the tc/ en-XA doesn't work* and we want an immediate feedback loop for i18n PRs we should bring back local en-XA generation!
Looks pretty dope too:
You can see why not having placeholders is dangerous:
Definite hack to get the nested braces to work for plurals, but hey it works:
*tc/ en-XA will work again once #9114 is landed and fully in tc/ 馃槃
can you explain this like i'm an idiot ... (just dig deep and pretend)
EDIT: oh, en-XA is some sort of test locale? that explains most of my confusion. is the point to show which parts of the UI are not actually being translated? If so, it kinda fails on numbers.
Yeah, basically. en-XA is a test locale that adds weird looking characters on every translatable character registered at that time. So when we have a PR like #9092 we could collect-strings, then look at a report in en-XA-local locale and it would be super obvious that something wasn't translated because it wouldn't have the messed up characters. Similarly we can see that the Learn More urls and all markup control characters are also messed up by this locale, indicating that they could be translated and messed up (e.g. #9000). So this is a simple and easy way to confirm that strings of new PRs are ready to translate.
It also has some cool stuff, notice, the metrics section the 1.0 s虃 indicating that the "s" for seconds is translated, but the Opportunities section has 0.63 s indicating that those seconds units haven't been translated! (that is part of #7238 to fix that very minor inconsistency)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revive locally generating
en-XA! Since the tc/en-XAdoesn't work* and we want an immediate feedback loop for i18n PRs we should bring back localen-XAgeneration!Looks pretty dope too:
You can see why not having placeholders is dangerous:
Definite hack to get the nested braces to work for plurals, but hey it works:
*tc/
en-XAwill work again once #9114 is landed and fully in tc/ 馃槃Related Issues/PRs
part of: #7238
Future work
ar-XBlocally too 馃槷