report: center and style top-level runtimeError #9271
Conversation
|
also, can this fix up for #7011? |
| margin-left: auto; | ||
| margin-right: auto; | ||
| width: 50%; | ||
| background-color: var(--color-amber); |
There was a problem hiding this comment.
feels like we might want a bit more padding with the new background style 🤷♂
There was a problem hiding this comment.
done and updated images
|
@exterkamp since this is his thing |
| @@ -35,6 +35,7 @@ | |||
| .lh-vars { | |||
| /* Palette using Material Design Colors | |||
| * https://www.materialui.co/colors */ | |||
| --color-amber: #FFF8E1; /* 50 */ | |||
There was a problem hiding this comment.
yeah I was confused too until I looked up the material ui table :) https://www.materialui.co/colors
There was a problem hiding this comment.
oh, in that case, should be part of the name.
Omit "-{intensity}" if there is only one color of that hue.
isn't simplifying anything if it's helpful enough to have the intensity that we add it in a comment :)
| padding: var(--category-padding); | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| width: 50%; |
There was a problem hiding this comment.
50% seems a little arbitrary and has the box edges not matching up with the "grid" of the report.
max-width: calc(var(--report-width) - var(--category-padding) * 2);this'll have it match most of the report content.
| } | ||
| @media screen and (max-width: 964px) { |
There was a problem hiding this comment.
once the max-width is applied you can drop this whole MQ and rule
Fixes #7011
Before:
See #9270
After:
