misc(build): generate report variants in deployment #9280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
commented
Jun 25, 2019
| @@ -237,6 +237,7 @@ class Runner { | |||
| gatherMode: undefined, | |||
| auditMode: undefined, | |||
| output: undefined, | |||
| channel: undefined, | |||
There was a problem hiding this comment.
mostly unrelated. just a driveby.
| // Generate and write reports | ||
| Object.entries(filenameToLhr).forEach(([filename, lhr]) => { | ||
| let html = ReportGenerator.generateReportHtml(lhr); | ||
| for (const variant of ['', '-devtools']) { |
There was a problem hiding this comment.
in the future, PSI will be another report variant.
patrickhulce
approved these changes
Jun 25, 2019
| @@ -152,6 +152,7 @@ | |||
| "jsonlint-mod": "^1.7.4", | |||
| "lighthouse-logger": "^1.2.0", | |||
| "lodash.isequal": "^4.5.0", | |||
| "lodash.set": "^4.3.2", | |||
There was a problem hiding this comment.
bundlephobia says this is 2KB minified+gzipped, so basically a nonfactor for folks already invoking npm install lighthouse 😆
| @@ -47,6 +47,7 @@ | |||
| "chrome": "node lighthouse-core/scripts/manual-chrome-launcher.js", | |||
| "fast": "yarn start --emulated-form-factor=none --throttlingMethod=provided", | |||
| "deploy-viewer": "yarn build-viewer --deploy", | |||
| "now-build": "node lighthouse-core/scripts/build-report-for-autodeployment.js", | |||
| const filenameToLhr = { | ||
| 'english': lhr, | ||
| 'espanol': swapLocale(lhr, 'es').lhr, | ||
| 'arabic': swapLocale(lhr, 'ar').lhr, |
There was a problem hiding this comment.
can we do en-xa-local once #9192 lands? 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our builder just gives us a single sample LHR report. But we'd like to see it in other languages and in a more devtools-like view.
e.g. https://lighthouse-git-deployvariants.googlechrome.now.sh/
I have another PR waiting that adds an LHR/report with lots of errors.