misc: localize logged GatherRunner error #9291
Conversation
|
fixes #8944 |
|
need to fix some test failures though |
ok, the test fixes are a little large, but I think help things. They don't overlap with the original commit but may be easier to review as a separate commit (e447753). The root cause was that those two failing tests were using mocked settings which didn't have a locale, so it was trying to do a lookup in I also updated the error message you get when you ask for an invalid locale (like You should probably take another look @patrickhulce :) |
| @@ -183,6 +183,8 @@ const _ICUMsgNotFoundMsg = 'ICU message not found in destination locale'; | |||
| */ | |||
| function _formatIcuMessage(locale, icuMessageId, fallbackMessage, values) { | |||
| const localeMessages = LOCALES[locale]; | |||
| if (!localeMessages) throw new Error(`Unsupported locale '${locale}'`); | |||
There was a problem hiding this comment.
this isn't something that should ever happen outside of tests since in a normal run we specifically pick which locale to use from the keys of LOCALES itself.
...but if it does somehow happen in a normal run, this is a strictly better error message than "Cannot read property 'lighthouse-core/lib/lh-error.js | pageLoadFailed' of undefined" anyways, so seems ok.
another tiny one, apologies for the spam:)Right now when you hit a pageLoadError you get a logged message like
GatherRunner:error lighthouse-core/lib/lh-error.js | pageLoadFailedInsecure # 0 https://expired.badssl.com/ +3msThis gets the full string for it.
fixes #8944edit: nope