[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: use CHROME_PATH variable in CI and scripts #9202

Merged
merged 2 commits into from
Jun 17, 2019
Merged

misc: use CHROME_PATH variable in CI and scripts #9202

merged 2 commits into from
Jun 17, 2019

Conversation

r0mflip
Copy link
Contributor
@r0mflip r0mflip commented Jun 14, 2019

No description provided.

@r0mflip r0mflip changed the title Update env variable chore: use CHROME_PATH variable in CI and scripts Jun 14, 2019
@r0mflip r0mflip changed the title chore: use CHROME_PATH variable in CI and scripts chor: use CHROME_PATH variable in CI and scripts Jun 14, 2019
@r0mflip r0mflip changed the title chor: use CHROME_PATH variable in CI and scripts core: use CHROME_PATH variable in CI and scripts Jun 14, 2019
patrickhulce
patrickhulce approved these changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator
@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @r0mflip!

Worth noting that support for this name does still exist in Chrome launcher, but we've just labelled it as deprecated.

@patrickhulce patrickhulce changed the title core: use CHROME_PATH variable in CI and scripts misc: use CHROME_PATH variable in CI and scripts Jun 14, 2019
@r0mflip
Copy link
Contributor Author
r0mflip commented Jun 14, 2019 •
edited
Loading

@patrickhulce Setting $CHROME_PATH alone just makes the script to exit. Even though I use the suggested variable name I would have to set $LIGHTHOUSE_CHROMIUM_PATH anyways. This PR changes that behavior.

Have a look at https://github.com/dump-yard/cbitosc.github.io/commit/029a208abb9f8feb9015ad772c8128a6f95c993d and https://travis-ci.org/dump-yard/cbitosc.github.io/builds/545699626 (ignore the state of the ci and repo)

@patrickhulce
Copy link
Collaborator

Even though I use the suggested variable name I would have to set $LIGHTHOUSE_CHROMIUM_PATH anyways

I understand; it's a good update to make us get off the deprecated chrome-launcher variable :) I was just also noting for other readers that this variable name does still work in chrome-launcher even though we change it for our download script here in Lighthouse.

@r0mflip
Copy link
Contributor Author
r0mflip commented Jun 14, 2019

I totally understand 😇

@r0mflip
Copy link
Contributor Author
r0mflip commented Jun 17, 2019

/pinging @patrickhulce @paulirish

@patrickhulce patrickhulce merged commit ebe7a22 into GoogleChrome:master Jun 17, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r0mflip @patrickhulce @googlebot