[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change score type from 'string' to 'number' #9225

Merged
merged 1 commit into from
Jun 17, 2019
Merged

docs: change score type from 'string' to 'number' #9225

merged 1 commit into from
Jun 17, 2019

Conversation

kaushikchaubal
Copy link
Contributor
@kaushikchaubal kaushikchaubal commented Jun 17, 2019 •
edited by patrickhulce
Loading

Summary

Changes documentation based on issue raised (#8901)

Documentation bug

Updated the type for 'score'

Related Issues/PRs

fixes #8901

patrickhulce
patrickhulce approved these changes Jun 17, 2019
View reviewed changes
Copy link
Collaborator
@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @kaushikchaubal! 💯 🎉

@patrickhulce patrickhulce changed the title #8901: Changing score from 'string' to 'number' docs: change score type from 'string' to 'number' Jun 17, 2019
@paulirish paulirish merged commit 5a229ac into GoogleChrome:master Jun 17, 2019
@paulirish paulirish mentioned this pull request Jun 17, 2019
Merged
@paulirish
Copy link
Member

@kaushikchaubal nice job! :D

@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong value in the type of "score" in the "Understanding result" documentation
4 participants
@kaushikchaubal @paulirish @patrickhulce @googlebot