tests: relax contrast font size expectation #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jul 24, 2019
| @@ -153,7 +153,8 @@ module.exports = [ | |||
| 'type': 'node', | |||
| 'selector': '#color-contrast', | |||
| 'snippet': '<div id="color-contrast" style="background-color: red; color: pink;">\n Hello\n </div>', | |||
| 'explanation': 'Fix any of the following:\n Element has insufficient color contrast of 2.59 (foreground color: #ffc0cb, background color: #ff0000, font size: 28.5pt, font weight: normal). Expected contrast ratio of 3:1', | |||
| // Default font size is different depending on the platform (e.g. 28.5 on travis, 30.0 on Mac), so use \d\d\.\d. | |||
| 'explanation': /^Fix any of the following:\n {2}Element has insufficient color contrast of 2\.59 \(foreground color: #ffc0cb, background color: #ff0000, font size: \d\d\.\dpt, font weight: normal\). Expected contrast ratio of 3:1$/, | |||
There was a problem hiding this comment.
the {2} is because we apparently have an eslint rule for not allowing multiple spaces in a row 🤷♀
paulirish
approved these changes
Jul 24, 2019
paulirish
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn smoke a11yfails incolor-contraston the Mac because the font size is different than Linux and the stricter expectations introduced in #8961 work on Linux :)This loosens up the requirement, which is fine because this is just the explanation string, not what the audit was testing.