[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(accessibility): add heading role to report category gauges #9422

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Conversation

johnemau
Copy link
Contributor
@johnemau johnemau commented Jul 20, 2019

Summary
Add role="heading" with aria-level="2" to the report category gauges so
screen readers can easily identify and navigate the report using headings.

Level 2 was chosen because Accessibility Insights recommends against
multiple level 1 headings in the same section of a document
.

Screenshot of gauges in the devtools accessibility tree
h2-accessibility-tree

Screenshot of NVDA Element List
h2-nvda-element-list

This meets the following WCAG 2.1 success criteria
1.3.1 Info and Relationships https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships
2.4.10 Section Headings https://www.w3.org/WAI/WCAG21/quickref/#section-headings

Related Issues/PRs
#7575

Add role="heading" with aria-level="2" to the report category gauges so
screen readers can easily identify and navigate the report using headings.

Level 2 was chosen because [Accessibility Insights recommends against
multiple level 1 headings in the same section of a document][1].

This meets the following WCAG 2.1 success criteria
1.3.1 Info and Relationships https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships
2.4.10 Section Headings https://www.w3.org/WAI/WCAG21/quickref/#section-headings

[1]: https://github.com/microsoft/accessibility-insights-web/blob/900c301e/src/content/adhoc/headings/guidance.tsx#L45-L54
Copy link
Collaborator
@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnemau johnemau changed the title report(accessibility): Add heading role to report category gauges report(accessibility): add heading role to report category gauges Jul 20, 2019
Copy link
Member
@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants