[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest 1.30.0 release fails to build on linux #23311

Closed
david-geiger opened this issue Jun 25, 2020 · 3 comments · Fixed by #23324
Closed

latest 1.30.0 release fails to build on linux #23311

david-geiger opened this issue Jun 25, 2020 · 3 comments · Fixed by #23324

Comments

@david-geiger
Copy link

Hi,

I tried on Mageia Cauldron to build latest 1.30.0 release but it fails to build with:

In file included from ./src/compiler/python_generator_helpers.h:29,
from ./src/compiler/protobuf_plugin.h:24,
from src/compiler/python_generator.cc:35:
./src/compiler/python_generator.h:47:12: error: 'uint64_t grpc_python_generator::PythonGrpcGenerator::GetSupportedFeatures() const' marked 'override', but does not override
47 | uint64_t GetSupportedFeatures() const override;
| ^~~~~~~~~~~~~~~~~~~~
src/compiler/python_generator.cc: In member function 'uint64_t grpc_python_generator::PythonGrpcGenerator::GetSupportedFeatures() const':
src/compiler/python_generator.cc:881:10: error: 'FEATURE_PROTO3_OPTIONAL' was not declared in this scope
881 | return FEATURE_PROTO3_OPTIONAL;
| ^~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:2945: /home/iurt/rpmbuild/BUILD/grpc-1.30.0/objs/opt/src/compiler/python_generator.o] Error 1
make: *** Waiting for unfinished jobs....

Full build log:
build.0.20200625044101.log

@Manu343726
Copy link

This is broken for the CMake build in the latest release, the above PR only fixes it for the makefile build

@Manu343726
Copy link
Manu343726 commented Jan 20, 2021

BTW it would be nice if the minimum protobuf version required was documented somewhere, I checked both this repo and the C++ getting started manual in the official docs and there's no mention about this, it only states "Protobuf 3".

@connor-bugler
Copy link

Bump, getting this error with baze on ubuntu as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants