[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding the docs of merge_and_unload #615

Closed
Narsil opened this issue Jun 22, 2023 · 4 comments
Closed

Expanding the docs of merge_and_unload #615

Narsil opened this issue Jun 22, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@Narsil
Copy link
Narsil commented Jun 22, 2023

Feature request

merge_and_unload seems like a super nice gateway to "cast down" a model into a simpler version usable by other hf tools like optimum, tgi etc..

I linked the doc here: huggingface/text-generation-inference#482 but I think a more complete documentation with examples and caveats would be nice.

Motivation

It's a very useful method to link back to other parts to the HF ecosystem without putting burden on other libs to reimplement peft logic.

Your contribution

I'm ok to write a PR, but probably not super knowledgeable about how to use and edge cases.

@Narsil
Copy link
Author
Narsil commented Jun 22, 2023

@younesbelkada

@younesbelkada younesbelkada added the documentation Improvements or additions to documentation label Jun 22, 2023
@younesbelkada
Copy link
Contributor

Totally agreed! cc @pacman100 as well and @stevhliu @MKhalusova FYI

@stevhliu
Copy link
Member

I opened #650 to add a basic example usage in the API docs, but we'll also benefit from a more comprehensive doc on it!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants