[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post PBB migration: Refactor "Move Closed Issues" workflow #7079

Open
9 tasks
Tracked by #6993
, #7075
...
t-will-gillis opened this issue Jun 28, 2024 · 1 comment
Open
9 tasks
Tracked by #6993
, #7075
...

Post PBB migration: Refactor "Move Closed Issues" workflow #7079

t-will-gillis opened this issue Jun 28, 2024 · 1 comment
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Feature: API Coding requires using an API Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Comments

@t-will-gillis
Copy link
Member
t-will-gillis commented Jun 28, 2024 •
edited
Loading

Dependency

Overview

The new Projects Beta is structured a little differently from Projects (classic). During to our recent migration from Projects (classic) to Projects Beta, we scrubbed our workflows and removed all functionality that referenced 'columns' as this term is no longer used. We need to refactor our post migration workflows so that they have similar functionality as previously.

Details

The move-closed-issues.yaml file is triggered when an issue is closed. It reviews which labels are on the issue, and prior to migration to Projects Beta, issues with a particular label were assigned to the "QA" column. This file's logic needs to be rewritten in terms of the 'status' field instead, using GraphQL.

Action Items

  • This issue involves GithHub Actions and GraphQL. You will need the new Project Board Beta set up in your repo so that you are able to test and demonstrate your solution. Refer to the "Resources/Instructions" section below to get started, and be sure to let us know if you have questions.
  • In move-closed-issues.yaml, refactor the code using GraphQL so that specific issues are sorted to the appropriate 'status' of "Done" or "QA".
  • Note that sort-closed-issues.js already has the conditionals in place and are reporting the correct final 'status' for each closed issue. Also note that Projects Beta automatically sorts all closed issues to "QA" status.
  • What remains is to use GraphQL to sort the appropriate issues to "QA" status:
    • One option is to do this after the automatic workflow has moved all issues to "QA" so that there is no conflict.
    • Another option is to remove the automatic workflow sort for the closed issues, and instead have move-closed-issues.yaml do all of the sorting.
  • Note also that the intent is that you will use existing modules wherever possible. Feel free to make edits and/or suggestions as long as these will work with the existing codebase.
  • Test in your repo and demonstrate that your solution works.

Resources/Instructions
@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours Feature: API Coding requires using an API labels Jun 28, 2024
@t-will-gillis t-will-gillis mentioned this issue Jun 28, 2024
Open
11 tasks
@t-will-gillis t-will-gillis added the Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly label Jun 28, 2024
@t-will-gillis t-will-gillis self-assigned this Jun 28, 2024
@t-will-gillis t-will-gillis added the Draft Issue is still in the process of being created label Jun 28, 2024
@github-actions GitHub Actions
Copy link

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@t-will-gillis t-will-gillis added Dependency An issue is blocking the completion or starting of another issue and removed Draft Issue is still in the process of being created labels Jul 22, 2024
This was referenced Jul 22, 2024
Open
Open
@t-will-gillis t-will-gillis removed their assignment Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Feature: API Coding requires using an API Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Projects
HfLA Website: Project Board
Status: Ice box
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t-will-gillis