[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript bug fix: "Schedule Friday" workflow #7080

Closed
3 tasks done
t-will-gillis opened this issue Jun 28, 2024 · 2 comments · Fixed by #7104
Closed
3 tasks done

JavaScript bug fix: "Schedule Friday" workflow #7080

t-will-gillis opened this issue Jun 28, 2024 · 2 comments · Fixed by #7104
Assignees
@t-will-gillis
Labels
Bug Something isn't working Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Comments

@t-will-gillis
Copy link
Member
t-will-gillis commented Jun 28, 2024 •
edited
Loading

Overview

There is a bug in the "Schedule Friday" workflow that causes it to fail during runtime. We need to address this bug so that the workflow completes. Note: although this involves GitHub Actions / workflows, the main priority is to identify the bug in the JavaScript file and demonstrate a solution.

Details

Refer to the Schedule Friday workflow logs. Starting with the June 7th run, the workflow fails due to an error:

Screenshot 2024-06-28 101949

Observations which may or may not be relevant:

  • This error appears to occur in find-linked-issue.js with the set of "Pre-work Checklists" beginning with issue 6882.
  • On the May 31st run, the same issue was processed and did not cause an error.
  • On the most recent run, the workflow processed more recent "Pre-work Checklists", but the error did not occur until it reached the batch of preworks beginning with 6882.
  • There was a recent PR Implemented hiding of outdated bot comments - #1976 #6550 that edited these files and might be related; however, the successful May 31st run happened after this PR was merged.
  • We migrated to the Projects Beta last week, and the PR PBB migration "Schedule Friday" #7055 also made edits to this workflow; however, the same error seems to be occurring with the same set of preworks.

Action Items

  • Review the workflow logs and the pertinent files and test what the problem might be
  • If you find the error, please propose a fix
  • Either way, present your findings to the Team

Resources/Instructions
@t-will-gillis t-will-gillis added Bug Something isn't working role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours labels Jun 28, 2024
@t-will-gillis t-will-gillis self-assigned this Jun 28, 2024
@t-will-gillis t-will-gillis added the Draft Issue is still in the process of being created label Jun 28, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Jul 13, 2024
@t-will-gillis t-will-gillis mentioned this issue Jul 13, 2024
Merged
@t-will-gillis
Copy link
Member Author

While reviewing the recommendations in #6840 (thank you, @joey-ma) , I re-reviewed the error that keeps stopping the "Schedule Friday" workflow at the same point (i.e. when reviewing issue 6882). I was unable to determine why the error repeatedly occurred at this specific issue: for some reason, the body of this specific "Pre-work Checklist" resolves to a 'null' value, and running matchAll() on a null value raises a TypeError. Note: this error does not occur with the set of pre-work issues before this one, nor with the set after. Since the return value from running findLinkedIssue() on a "Pre-work Checklist" will be 'false' or 'null' or 'falsy' (there are no linked issues), it is safe to wrap let matches = text.matchAll(re) in a try-catch, log the TypeError at 6882, and let the function run to completion.

@t-will-gillis t-will-gillis mentioned this issue Jul 13, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-will-gillis t-will-gillis

Labels
Bug Something isn't working Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Projects
HfLA Website: Project Board
Status: QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix find-linked-issue.js for "Schedule Friday" t-will-gillis/website
1 participant
@t-will-gillis