[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img tag refactor in CONTRIBUTING.md Sec 2.7.d #7098

Open
1 of 5 tasks
Tracked by #6453
roslynwythe opened this issue Jul 8, 2024 · 5 comments
Open
1 of 5 tasks
Tracked by #6453

img tag refactor in CONTRIBUTING.md Sec 2.7.d #7098

roslynwythe opened this issue Jul 8, 2024 · 5 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member
roslynwythe commented Jul 8, 2024

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

  • In your local IDE, open the file CONTRIBUTING.md
  • In Section 2.7.d change
<img src="https://docs.github.com/assets/cb-49937/images/help/repository/update-branch-button.png" />

to

<img src="https://docs.github.com/assets/cb-49937/images/help/repository/update-branch-button.png">


- [ ] The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.

  • Changes to CONTRIBUTING.md cannot be tested locally, rather they must be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL (also store the test URL for use in a later step)
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/roslynwythe/website/blob/test-CONTRIB/CONTRIBUTING.md)

  • Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.
For Reviewers: Do not test changes locally, rather test changes at [REPLACE WITH TEST URL]

Merge Team

Resources/Instructions

  1. Webpage(s): https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
  2. This issue is part of epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 8, 2024

This comment was marked as outdated.

@roslynwythe roslynwythe added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML size: 0.5pt Can be done in 3 hours or less Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 8, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the x. Technical debt milestone Jul 9, 2024
@santisecco santisecco self-assigned this Jul 12, 2024
Copy link

Hi @santisecco, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@santisecco santisecco assigned santisecco and unassigned santisecco Jul 12, 2024
Copy link

Hi @santisecco, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@santisecco
Copy link
Member

i. Availability: Today 7-23 and 7-24
ii. ETA: 7-25

@santisecco
Copy link
Member

Hi, I have a blocker.

I opened CONTRIBUTING.md from the following path in my local folder hackforla\website\CONTRIBUTING.md but couldn't find

<img src="https://docs.github.com/assets/cb-49937/images/help/repository/update-branch-button.png" />

Instead I found in section 2.7.d

<img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />

I couldn't find the specified img tag in another place though.
Any assistance is appreciated, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Status: In progress (actively working)
Development

No branches or pull requests

3 participants