[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api-actionnetwork.js script from default markdown layout templates #7091

Open
2 tasks
Tracked by #6677
roslynwythe opened this issue Jul 7, 2024 · 3 comments
Open
2 tasks
Tracked by #6677
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member
roslynwythe commented Jul 7, 2024

Overview

We need to remove script references to api-actionnetwork.js from our default markdown template, because the script is no longer required.

Action Items

  • Open _layouts/default-markdown.html in your IDE
  • Remove the script tag that references assets/js/api-actionnetwork.js

Resources/Instructions

Liquid templating language

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 7, 2024

This comment was marked as outdated.

@roslynwythe roslynwythe changed the title Remove api-actionnetwork.js script from layout templates Remove api-actionnetwork.js script from default markdown layout templates Jul 7, 2024
@roslynwythe roslynwythe added Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less Feature: Refactor HTML role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers ready for product and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jul 7, 2024
@roslynwythe
Copy link
Member Author

@ExperimentsInHonesty I just want to confirm that we are not using actionnetwork and there is no need for testing to confirm that.

@ExperimentsInHonesty
Copy link
Member

@roslynwythe We stopped using actionnetwork 5 years ago.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Status: New Issue Approval
Development

No branches or pull requests

2 participants