[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Visibility Icons on Authorization pages are inverted #258

Closed
Atharv-Joshi opened this issue Nov 9, 2021 · 6 comments · Fixed by #259
Closed

Password Visibility Icons on Authorization pages are inverted #258

Atharv-Joshi opened this issue Nov 9, 2021 · 6 comments · Fixed by #259
Assignees
Labels
bug Something isn't working hacktoberfest

Comments

@Atharv-Joshi
Copy link
Contributor

Bug Report 🐛

Visibility Icons in Authorization pages are inverted

When password is hidden the icon should be
Screenshot 2021-11-10 004639
while it is
Screenshot 2021-11-10 004719
Also the colors aren't consistent with app theme

Expected Behavior

When password is hidden the icon should be
Screenshot 2021-11-10 004639
while it is
Screenshot 2021-11-10 004719
When password is visible the icon color can be warning color and if hidden it can be primary color or background color

Screenshot 2021-11-10 005440

I would also like to add a back button to login page from sign up page as is already present from login to signup

Current Behavior

When password is hidden the icon is
Screenshot 2021-11-10 004719
instead of
Screenshot 2021-11-10 004639
Also the colors aren't consistent with app theme

Possible Solution

inverting icon names in codebase

Steps to Reproduce

  1. No specific conditions needed.
  2. IS present on Login and Signup Page

Context (Environment)

Desktop

  • OS: [e.g. macOS]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 0.22.15]

Detailed Description

Possible Implementation

@welcome
Copy link
welcome bot commented Nov 9, 2021

Hello there!👋 Welcome to the project!🚀⚡
Thank you and congrats🎉 for opening your very first issue in this project. Please make sure to go through our Code of Conduct and contributing files and also please wait till you are assigned an issue to start working on it.😊

@github-actions github-actions bot added bug Something isn't working hacktoberfest labels Nov 9, 2021
@Atharv-Joshi
Copy link
Contributor Author

Can I work on this?

@warpaltarpers
Copy link

I don't think this is a bug; while "flip-flop" buttons like the one in question aren't considered the best option because they don't tell you the current state, the standard is that the icon should show what will happen when you click/tap on it. So, the current behavior lines up with the standard.

@Atharv-Joshi
Copy link
Contributor Author

Yeah , the button state confused me for a second while exploring the app , ig something like show/hide would be more appropriate?

@himanshusharma89
Copy link
Owner

Hi @Atharv-Joshi, pardon me for the delayed response. Sure, you can work on this.

@Atharv-Joshi
Copy link
Contributor Author

Hi @Atharv-Joshi, pardon me for the delayed response. Sure, you can work on this.

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
3 participants