[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced Dimension Plot #205

Closed
rh680 opened this issue Jun 1, 2018 · 3 comments
Closed

Reduced Dimension Plot #205

rh680 opened this issue Jun 1, 2018 · 3 comments

Comments

@rh680
Copy link
rh680 commented Jun 1, 2018

It would be great to be able to label tSNE/PCA plots with two parameters at once. For example, the condition could be represented by the shape or size of the point while the gene expression is depicted through the colour.

@kevinrue
Copy link
Member
kevinrue commented Jun 9, 2018

Hi @rh680 ,

Thank you for your feedback. We haven't forgotten about this issue.
Can you please rename the issue to "Point shaping options for dot plots"?
I think this states more specifically the feature you're requesting.

While offering a dropdown to select a variable for the shape aesthetic is straightforward, note that this feature requires the slightly less trivial task of identifying and restricting choices to 'discrete' (i.e., categorical) variables (point shape does not make sense for continuous variables). In other words, if we don't restrict choices to only 'groupable' variables, there is a risk of the app freezing if the default (i.e. first) variable in the dropdown is continuous.
This issue being also relevant for #181 which is ongoing, we'll probably fix both simultaneously, and make it available in the next release.

Best wishes

@kevinrue
Copy link
Member

Progress report: shape control is implemented in b458acc , although the faceting feature is currently unstable here due to ongoing work

@kevinrue
Copy link
Member

I'll mark this issue closed by a9b3fb3
It will be made available in the next version of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants