[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brushing: the dream #26

Closed
LTLA opened this issue Dec 20, 2017 · 4 comments
Closed

Brushing: the dream #26

LTLA opened this issue Dec 20, 2017 · 4 comments
Labels
enhancement

Comments

@LTLA
Copy link
Member
LTLA commented Dec 20, 2017

We should have brushing enabled on all plots where cells are the dots. The aim is to brush on one plot and see the results on any cell-based plot in any of the tabs.

This should be very possible, the question is how reactive it should be. Full reactivity would be too slow for large numbers of plots; I am more inclined to have a button on the left with "highlight selected" that a user can press once they've gotten the points they want. Such a button could also be plot-specific, making use of another collapsible box in the plotting parameters for each plot.
@LTLA
Copy link
Member Author
LTLA commented Dec 24, 2017 •
edited
Loading

Partially addressed in #29, but I'm waiting for custom ggplot calls instead of going via scater to achieve effective brushing input from all plots.

@davismcc
Copy link

I find the "brushing" confusing. The term itself is not familiar to me, so I don't immediately intuit what it should do and the help doesn't explain it in enough detail. I suggest we have a help item particularly for brushing that could pop up for people to see/remind what it is without going through the tour again.

@federicomarini
Copy link
Contributor

the "brushing" in context of interactive plot is to be intended in the shiny-way, i.e. as in https://shiny.rstudio.com/articles/plot-interaction.html.

Another way to call it would be something related to "linking plots" to something, or also linked plots.

I think the first time I saw the brushing in this context was from an excellent book of Tamara Munzner, but I can think not everyone is familiar with the context.
I'll add one item to the intros tour to tell what the user can do with it.

@LTLA
Copy link
Member Author
LTLA commented Jan 22, 2018

Done in #65.

@LTLA LTLA closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davismcc @federicomarini @LTLA