[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ideal history log #27

Closed
LTLA opened this issue Dec 20, 2017 · 8 comments
Closed

The ideal history log #27

LTLA opened this issue Dec 20, 2017 · 8 comments

Comments

@LTLA
Copy link
Member
LTLA commented Dec 20, 2017

We should get something similar to ideal in reporting the commands used to generate each plot. This makes it very easy for people to copy-paste the commands to generate the plot after it's been done.

@federicomarini
Copy link
Contributor

We can consider this solved after #67

@LTLA
Copy link
Member Author
LTLA commented Jan 20, 2018

Almost. Can you merge master into brush_integration? (Not the other way around, at least not yet.) There are probably two elements that need to be added to the top of the code output from codetrack.R:

  • se <- XXX where XXX is the variable name for the input object; see Slack discussions.
  • all.coordinates <- list() to enable storage of brushed points.

@federicomarini
Copy link
Contributor

I did not catch up with the brushing part, but I'll look into it.
Merged the newest version to track code also here in brush_integration

@kevinrue
Copy link
Member

I can still add se <- XXX before merging to master. Not sure what you mean about all.coordinates though

@LTLA
Copy link
Member Author
LTLA commented Jan 21, 2018

You'll notice in iSEE.R that every transmitting plot (i.e., with .brushActive field being TRUE) adds a command to store the plot coordinates into all.coordinates. This ensures that a separate receiving plot can properly determine the points that were brushed in the transmitting plot. Obviously, this also means that we need to define all.coordinates at the start of the code output by code_track.R.

@kevinrue
Copy link
Member

Indeed. Not sure how to best do this, so I'll leave it for tomorrow or one of you.

@kevinrue
Copy link
Member

Note to self (and users):
I was going to ask whether the tracker could include a button 'copy to clipboard' , out of laziness to drag my mouse over all the script.
However, I just noticed that one can click inside the aceEditor and then hit Cmd-A to select everything.

@LTLA
Copy link
Member Author
LTLA commented Jan 21, 2018

Fixed with fbff388, closing.

@LTLA LTLA closed this as completed Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants