[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional column with user-friendly gene_name #33

Closed
kevinrue opened this issue Jan 12, 2018 · 4 comments
Closed

optional column with user-friendly gene_name #33

kevinrue opened this issue Jan 12, 2018 · 4 comments
Assignees

Comments

@kevinrue
Copy link
Member

while unique gene ids (e.g. ensemble_gene_id) are necessary to fetch data from the object, it would be nice to let users select an optional column of the Gene statistics table that contains a user-friendly gene symbol to annotate the plot (e.g. ggplot(...) + labs(subtitle = ...)).
The widget to select this would be in an expandable "plotting parameters" panel under the Gene statistics table.

@kevinrue kevinrue self-assigned this Jan 12, 2018
@LTLA
Copy link
Member
LTLA commented Jan 12, 2018

A much simpler solution would be for people to change the row names prior to calling iSEE.

@kevinrue
Copy link
Member Author

I just want to avoid falling in the Seurat choice of make.unique on the gene names.

@LTLA
Copy link
Member
LTLA commented Jan 12, 2018

If it's a big deal, I would use the approach in section 2.3 here (I'll move it to scater). The fact remains that somewhere along the line, if the gene names are not unique, there needs to be a way to disambiguate them. Hiding the ambiguities would probably be even worse for data exploration.

Moreover, if people want a nicer plot annotation, they can do that outside the app once they have the code from @federicomarini's log. It shouldn't be a particularly complex change.

@LTLA
Copy link
Member
LTLA commented Jan 21, 2018

Closing this, scater now has a uniquifyFeatureNames function for this purpose.

@LTLA LTLA closed this as completed Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants