[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul handling of global options #554

Closed
LTLA opened this issue Apr 2, 2021 · 0 comments · Fixed by #555
Closed

Overhaul handling of global options #554

LTLA opened this issue Apr 2, 2021 · 0 comments · Fixed by #555

Comments

@LTLA
Copy link
Member
LTLA commented Apr 2, 2021

Most of the global options in iSEEOptions() are constructor-level flags. These are largely harmless for reproducibility as they do not affect the operation of iSEE() itself, conditional on the Panels being supplied.

However, there are a few parameters that do not follow this pattern, e.g., the maximum factor levels. I propose storing those as parameters inside the SummarizedExperiment, so that the combination of SE + list of Panels is necessary and sufficient to recover any given application state. (Well, aside from parts of the DT::DataTable, but that can't be helped.)

To this end, iSEEOptions() should be renamed to defaultPanelOptions(), retaining most of its functionality; the few application-wide globals should be shifted into a setGlobalOptions() function that stores the values in the SE itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant