[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken geneExprsPlot for discrete X axis #68

Closed
kevinrue opened this issue Jan 21, 2018 · 3 comments
Closed

broken geneExprsPlot for discrete X axis #68

kevinrue opened this issue Jan 21, 2018 · 3 comments

Comments

@kevinrue
Copy link
Member

.violin_plot should be called to handle this scenario (X discrete, Y continuous)
check whether .scatter_plot gets called instead (that would call range() on a discrete value, which doesn't work)
@LTLA
Copy link
Member
LTLA commented Jan 21, 2018

It will call .scatter_plot if there's too many values - but there should be a .coerce_to_numeric somewhere to protect the range() call.

@kevinrue
Copy link
Member Author

fixed by 5fa8a02
need to find a cleaner way to preserve axis ranges upon brushing in restrict mode, for violins

@LTLA
Copy link
Member
LTLA commented Jan 21, 2018

I'm actually fine with restricting the points only, and leaving the violins computed using the full set of data. This is technically most consistent with what brushing is meant to do in the other plots. Recalculation of the violins is nice but conflates the brushing with the plotting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinrue @LTLA