[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS error when loading HTML page via fs: protocol handler #3

Closed
lidel opened this issue Mar 24, 2015 · 2 comments
Closed

Fix CORS error when loading HTML page via fs: protocol handler #3

lidel opened this issue Mar 24, 2015 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
v0.2.0

Comments

@lidel
Copy link
Member
lidel commented Mar 24, 2015

Opening page with JavaScript via ipfs: protocol handler results in CORS error.
Example: ipfs:QmSrCRJmzE4zE1nAfWPbzVfanKQNBhp7ZWmMnEdbiLvYNh/mdown#sample.md

2015-03-24-234358_976x500_scrot

Bit late today, will look into this later this week.
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Mar 24, 2015
@lidel lidel modified the milestone: v1.0.0 Mar 25, 2015
@lidel lidel added wontfix and removed kind/bug A bug in existing code (including security flaws) labels Mar 25, 2015
@lidel
Copy link
Member Author
lidel commented Mar 25, 2015

After closer consideration relying on virtual protocol opens a pandora box with various security implications.
We will minimize use of custom protocol handler (#7), and as a result this issue will not occur.

@lidel lidel closed this as completed Mar 25, 2015
@lidel lidel reopened this Mar 25, 2015
@lidel
Copy link
Member Author
lidel commented Mar 25, 2015

This issue still occurs when we disable gateway redirect and a dependent resource or a relative link is loaded from http://gateway.ipfs.io/ipfs/<hash> while main page being from ipfs:<hash>.
As a result CORS blocks JS execution across different domains.

@lidel lidel added kind/bug A bug in existing code (including security flaws) and removed wontfix labels Mar 25, 2015
@lidel lidel closed this as completed in 9ca515a Mar 25, 2015
@lidel lidel added this to the v0.2.0 milestone Mar 25, 2015
@lidel lidel mentioned this issue Apr 13, 2015
Closed
@the8472 the8472 mentioned this issue Dec 15, 2015
Closed
@the8472 the8472 mentioned this issue Feb 11, 2016
Merged
@lidel lidel changed the title Fix CORS error when loading HTML page via ipfs: protocol handler Fix CORS error when loading HTML page via fs: protocol handler Feb 14, 2016
@lidel lidel reopened this Feb 14, 2016
@lidel lidel closed this as completed Feb 14, 2016
@lidel lidel mentioned this issue Feb 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@lidel