[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localhost:8080/ipfs/<CID> redirects to <CID>.ipfs.localhost:8080 which fails on Windows. #1595

Closed
MicahZoltu opened this issue Jul 29, 2020 · 3 comments · May be fixed by baby636/ipfs-desktop#4
Closed

localhost:8080/ipfs/<CID> redirects to <CID>.ipfs.localhost:8080 which fails on Windows. #1595

MicahZoltu opened this issue Jul 29, 2020 · 3 comments · May be fixed by baby636/ipfs-desktop#4
Labels
need/triage Needs initial labeling and prioritization status/duplicate A question or request for support

Comments

@MicahZoltu
Copy link
  • OS: Windows
  • Version of IPFS Desktop: 0.12.2

Describe the bug
Navigating to localhost:8080/ipfs/<CID> redirects me to <CID>.ipfs.localhost:8080 (this is a very good thing for security!), but that address doesn't actually work in my browser.

To Reproduce
Steps to reproduce the behavior:

  1. Install IPFS Desktop on Windows 10.
  2. Navigate to http://localhost:8080/ipfs/QmQy6xmJhrcC5QLboAcGFcAE1tC8CrwDVkrHdEYJkLscrQ
  3. Notice that you were redirected to http://bafybeibhbx3y6tnn7q4gpsous6apnobft5jybvroiepdsmvps2lmycjjxu.ipfs.localhost:8080/
  4. Be sad that you are getting a DNS error in your browser.

Expected behavior
The redirect is expected and desired as it greatly improves the security of running a web application via IPFS. However, I expected that the domain would resolve correctly.

Additional context
I am aware that I can browser via http://127.0.0.1:8080/ipfs/<CID>, but that is not secure for running web apps that have important data saved in cookies/local storage. I very much want to use the subdomains, and the automatic redirect is great. However, it currently redirects me to a site that doesn't resolve.
@MicahZoltu MicahZoltu added the need/triage Needs initial labeling and prioritization label Jul 29, 2020
@jessicaschilling
Copy link
Contributor

@lidel and/or @rafaelramalho19 -- are you able to triage? Thank you!

@MicahZoltu
Copy link
Author

It appears this works correctly in Chrome, but not in Firefox.

@lidel lidel added the status/duplicate A question or request for support label Jul 29, 2020
@lidel
Copy link
Member
lidel commented Jul 29, 2020 •
edited
Loading

Closing this, as we already have upstream issue for this (more details there): https://github.com/ipfs/go-ipfs/issues/7527

Workaround for Firefox users is to install IPFS Companion: https://addons.mozilla.org/en-US/firefox/addon/ipfs-companion/ → @MicahZoltu give it a try!

@lidel lidel closed this as completed Jul 29, 2020
@snyk-bot snyk-bot mentioned this issue May 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization status/duplicate A question or request for support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade i18next from 19.4.4 to 20.2.1 baby636/ipfs-desktop
3 participants
@lidel @MicahZoltu @jessicaschilling