[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Migrate from Castle.Core to System.Reflection.DispatchProxy #150

Closed
Lakritzator opened this issue Jun 28, 2020 · 3 comments
Closed

[Suggestion] Migrate from Castle.Core to System.Reflection.DispatchProxy #150

Lakritzator opened this issue Jun 28, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
3.0.4

Comments

@Lakritzator
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There is a dependency on a project, Castle.Proxy, which is not bad but I believe it makes more sense to stick with the bare functionality of, as this might give better support on the long run for features that .NET 5 bring.

Describe the solution you'd like
Migrate to System.Reflection.DispatchProxy

Describe alternatives you've considered
Ignore that Castle.Proxy is used, live with it. 🤷‍♂️

Additional context
I'd be more than happy to have a go, just wanted to ping to see if you would be interested in a PR.
One warning though, although I know my way around DispatchProxy, I currently seem to get tied up in to much stuff,
I didn't have a detailed look at this library, but it was on my list of possible solutions for having a new instance of an application talk to the already running instance, and this was discussed here: dapplo/Dapplo.Microsoft.Extensions.Hosting#11

I might also have misunderstood your usage, I only took around 10 minutes going through your code...
@jorisvergeer jorisvergeer mentioned this issue Jul 4, 2020
Merged
@jorisvergeer
Copy link

@Lakritzator I gave it a go.

@Lakritzator
Copy link
Contributor Author

@jorisvergeer I hope I still get 5% of the credit, but great work 👍

@jacqueskang jacqueskang added the enhancement New feature or request label Jul 5, 2020
@jacqueskang jacqueskang modified the milestones: 3.1.0, 3.0.4 Jul 5, 2020
@jorisvergeer
Copy link

@Lakritzator I would give you more credit than 5 percent. It was your solution after all.

And I learned something new 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.4
Development

No branches or pull requests
3 participants
@Lakritzator @jorisvergeer @jacqueskang