[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP: Route Port Matching #957

Closed
howardjohn opened this issue Dec 6, 2021 · 3 comments · Fixed by #966 or #2777
Closed

GEP: Route Port Matching #957

howardjohn opened this issue Dec 6, 2021 · 3 comments · Fixed by #966 or #2777
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP)

Comments

@howardjohn
Copy link
Contributor

What would you like to be added: support for port matching in routes

Why this is needed:

Mesh (primary use case): for mesh, we are using a parentRef of Mesh, instead of Gateway. As such, there is no port matching available, since we do not get ports in the Gateway.listener like we do with Gateway cases. Matching on ports is quite common in mesh; for example, if I am defining some policy for google.com, I know I only need this for port 80 since google isn't serve on 8080.
Ingress (secondary use case): This is similar to hostname attachment in many ways. Rather than requiring a bunch of sectionNames, I want to attach to multiple sections at once by filtering by port instead of explicit listener reference

Prior art: https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPMatchRequest has a port field

Design ideas:

  • Add it to TrafficMatches from GEP 735 L4 Traffic Matching #932. This only applies to TCP/UDP route though; we would need this in HTTP and TLS as well
  • Use sectionName (ie sectionName: "80"). This would work but is a bit odd since port is a string here. Would only apply to mesh
  • Add a new port field to parentRef. For Gateway, this would act as an additional filter on listeners bound. For mesh, this would scope to that port.
@howardjohn howardjohn added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2021
@robscott robscott changed the title Add Port Matching in routes GEP: Route Port Matching Dec 2, 2023
@robscott
Copy link
Member
robscott commented Dec 2, 2023

Leaving this open until this GEP either graduates to standard or is removed from the API.

/kind gep
/reopen

@k8s-ci-robot k8s-ci-robot added the kind/gep PRs related to Gateway Enhancement Proposal(GEP) label Dec 2, 2023
@k8s-ci-robot k8s-ci-robot reopened this Dec 2, 2023
@k8s-ci-robot
Copy link
Contributor

@robscott: Reopened this issue.

In response to this:

Leaving this open until this GEP either graduates to standard or is removed from the API.

/kind gep
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaneutt
Copy link
Member

/assign @frankbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP)
Projects
5 participants