[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Trigger Event(s) #29

Open
johndodev opened this issue Jan 6, 2021 · 2 comments
Open

[feature request] Trigger Event(s) #29

johndodev opened this issue Jan 6, 2021 · 2 comments
Labels
feature-request 🙏🏻

Comments

@johndodev
Copy link
johndodev commented Jan 6, 2021 •
edited
Loading

The problem

It would be nice if, as the symfony mailer, an event would be dispatched just before a notification was send to allow to alter the message in a large scale.

For example, today I have notifications sent to a flutter app. Flutter apps need a custom "data" to proper handle it :

Notification is delivered to system tray. When the user clicks on it to open app onResume fires if click_action: FLUTTER_NOTIFICATION_CLICK is set (see below).
https://pub.dev/packages/firebase_messaging#receiving-messages

So I need to add the data [click_action => FLUTTER_NOTIFICATION_CLICK] to all my notifications on my code, which is dirty, and it couple the code to flutter, which is dirtier.

But if I had an event I could add this data to all notification in only one place (a subscriber), and delete it if the mobile app comes to stop using flutter.

What do you think ?
@johndodev johndodev changed the title [feature requests] Trigger Event(s) [feature request] Trigger Event(s) Jan 6, 2021
@github-actions
Copy link
Contributor
github-actions bot commented Mar 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Mar 8, 2021
@jeromegamez jeromegamez added feature and removed Stale labels Mar 8, 2021
@settings settings bot removed the feature label Sep 22, 2022
@github-actions
Copy link
Contributor
github-actions bot commented Oct 7, 2022

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let me know if that works for you by leaving a 👍. Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request 🙏🏻
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromegamez @johndodev