[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-* dependency maintenance #2511

Open
NickDarvey opened this issue Jun 22, 2024 · 1 comment
Open

aws-* dependency maintenance #2511

NickDarvey opened this issue Jun 22, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file rust Rust related tasks

Comments

@NickDarvey
Copy link
Contributor

Building my Rust project with lancedb@0.5 with aarch64-pc-windows fails because this architecture isn't supported with ring@0.16 1, which is a dependency because lancedb | lance -> lance-index -> lance-io -> aws-config@0.56 -> ring@0.16. Support for aarch64-pc-windows is available in ring@0.17 2.

Potential fixes

  1. Updating aws-config

    chore: upgrade aws-config for aarch64-pc-windows support #2510

    This PR bumps a minor version. However, the aws-* dependencies are depending on pre-release versions. The production-ready versions (1+) are now available. Maybe this is worth scheduling in Roadmap 2024 #2079? (However, I'm guessing there are plenty of breaking changes.)

  2. Making the aws libs optional

    Could we make these dependencies optional by making them part of cargo feature named 'aws' for lance-io, lance-index, lance, and lancedb? I am not using AWS for my project, perhaps others aren't either.

    This feature could be enabled by default in lance and lancedb for backwards compatibility.

Workaround

In your Cargo.toml, add:

[patch.crates-io]
lance-io = { git = "https://github.com/nickdarvey/lance", branch = "patch-2" }

Footnotes

  1. https://github.com/briansmith/ring/issues/1514

  2. https://github.com/briansmith/ring/issues/1167#issuecomment-1745560468

@wjones127
Copy link
Contributor

I agree we should make aws libs optional.

@wjones127 wjones127 added rust Rust related tasks dependencies Pull requests that update a dependency file labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Rust related tasks
Projects
None yet
Development

No branches or pull requests

2 participants