[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] game not found when trying to access a master game not yet imported from the explorer #16050

Closed
veloce opened this issue Sep 12, 2024 · 2 comments
Closed

[Mobile] game not found when trying to access a master game not yet imported from the explorer #16050

veloce opened this issue Sep 12, 2024 · 2 comments

Comments

@veloce
Copy link
Contributor
veloce commented Sep 12, 2024

Original mobile issue: lichess-org/mobile#1008

Currently on the app when a user requests to open a master game we're using this endpoint: GET /game/export/<id>

The website is opening a new browser window to this url: /import/master/<id>/<color> which does redirect to the regular game url after importing the game if necessary.

If we want to do the same on the application, I'd expect the GET /import/master/<id> endpoint to deal with the import and return the same JSON as in GET /game/export/<id>, if that is possible.
@veloce
Copy link
Contributor Author
veloce commented Sep 12, 2024

While I'm at it, it would be also nice to include in the game JSON the date of the master game. Because currently I'm showing the date of the import, which is not the same as the date shown in the explorer.

@ornicar
Copy link
Collaborator
ornicar commented Sep 19, 2024 •
edited
Loading

how about you call GET /import/master/$id<\w{8}>/:color first
then GET /game/export/<id>.

that's 2 requests but:

  • it's a relatively rare use case
  • that's what the browser client also does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ornicar @veloce