[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error on Java 7 #394

Closed
gwilym opened this issue Feb 8, 2018 · 1 comment
Closed

Compile error on Java 7 #394

gwilym opened this issue Feb 8, 2018 · 1 comment

Comments

@gwilym
Copy link
Contributor
gwilym commented Feb 8, 2018

Secor no longer compiles on Java 7 because of some use of Java 8+ features.

Full log: https://api.travis-ci.org/v3/job/338143233/log.txt

Sample:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/pinterest/secor/src/main/java/com/pinterest/secor/util/ProtobufUtil.java:[71,37] cannot find symbol
  symbol:   method putIfAbsent(java.lang.String,java.lang.String)
  location: variable messageFormatByTopic of type java.util.Map<java.lang.String,java.lang.String>
[ERROR] /home/travis/build/pinterest/secor/src/main/java/com/pinterest/secor/util/ProtobufUtil.java:[205,69] cannot find symbol
  symbol:   method getOrDefault(java.lang.String,java.lang.String)
  location: variable messageFormatByTopic of type java.util.Map<java.lang.String,java.lang.String>
[INFO] 2 errors

(I think this was brought in with #387 @achad4)

Not sure what the direction for Secor is here. Should Secor be bumped to require Java 8, or should the code be updated to be compatible with Java 7?
@HenryCaiHaiying
Copy link
Contributor

I am inclined to deprecate the support for java7 since Oracle no longer supports it.

@gwilym gwilym mentioned this issue Feb 8, 2018
Closed
@norrs norrs mentioned this issue Apr 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gwilym @HenryCaiHaiying