[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Dropdown Search must prioritize front matches before body matches #1232

Open
marketemp opened this issue May 5, 2020 · 2 comments
Open

[BUG] Dropdown Search must prioritize front matches before body matches #1232

marketemp opened this issue May 5, 2020 · 2 comments

Comments

@marketemp
Copy link 
I am using:

dash                 1.11.0
dash-core-components 1.9.1
dash-html-components 1.0.3
dash-renderer        1.4.0
dash-table           4.6.2

This issue is not Front-End Related

**Describe the bug**

I am using the dcc.Dropdown with a list of over 5000 stock ticker symbols.  If I select any letter besides A, I am presented with all of the stocks that include that letter, not all of the stocks that begin with that letter.  It is therefore impossible to access the stock I am looking for without typing it out entirely, or using the scrollbar and manually scrolling down to it (required for 1 and 2 character symbols).  For example (screenshots), by typing M, I am offered AAMC, AAE, ABM, and 349 other symbols before getting to the one I want M (Macy's) and even hard-typing M (Enter) returns AAMC, which is why I this should be considered a bug and not a feature request.

**Expected behavior**

It would be expected that a dropdown searchbar prioritize front matches before body matches.  Body matches are nice, but most dropdown bars I've used only return front matches and ignore body matches.

**Screenshots**

Screenshots are attached as well as a file including my list of stock symbols to use as labels

Screen Shot 2020-05-05 at 4 03 49 PM

Screen Shot 2020-05-05 at 4 07 48 PM

[syms.txt](https://github.com/plotly/dash/files/4583478/syms.txt)
@marketemp marketemp mentioned this issue May 5, 2020
Open
@marketemp
Copy link
Author

chriddyp pointed me to the Dynamic Options example on https://dash.plotly.com/dash-core-components/dropdown and I solved it using:

return [o for o in options if re.match(search_value, o["label"], re.IGNORECASE)]

for front matches only or:

opt = [o for o in options if re.match(search_value, o["label"], re.IGNORECASE)]
opt.extend([o for o in options if o not in opt and search_value in o["label"]])
return opt

for front matches, then body matches. It still would be great if search worked this way, or there was an option to make search work this way using the options= argument of the dcc.Dropdown component.

@snyk-bot snyk-bot mentioned this issue May 9, 2021
Open
This was referenced Sep 15, 2021
Open
Open
@kmcminn
Copy link
kmcminn commented Sep 17, 2021

expanded workaround for any wanders out there. tl;dr add another callback on your components to rewrite options.

# <snip> typical dash imports and vanilla app setup
labels = ["apple", "orange", "pear"]
options = [{'label': s[0], 'value': s[1]} for s in zip(labels, labels)]
app.layout = html.Div([
        dcc.Dropdown(
        id='my-dropdown',
        options=options,
        searchable=True,
        value=[],
        multi=True
    ),
])
    
@app.callback(
    dash.dependencies.Output("my-dropdown", "options"),
    [dash.dependencies.Input("my-dropdown", "search_value")],
)
def update_options(search_value):
    opt = [o for o in options if o["label"].lower().startswith(search_value.lower())] 
    opt.extend([o for o in options if o not in opt and search_value in o["label"]]) 
    return opt

@baby636 baby636 mentioned this issue Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@baby636 baby636 mentioned this issue Nov 5, 2022
Open
@baby636 baby636 mentioned this issue Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this issue Dec 26, 2022
Open
@baby636 baby636 mentioned this issue Dec 26, 2022
Open
This was referenced Jun 21, 2023
Open
Open
This was referenced Nov 27, 2023
Open
Open
Open
This was referenced Dec 20, 2023
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmcminn @marketemp