{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":615010916,"defaultBranch":"main","name":"spin","ownerLogin":"psarna","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-03-16T19:11:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/10433047?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1698919187.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"f7c0b6c454f662b9216cf7f75cf42a069461d380","ref":"refs/heads/outputsymbols_main","pushedAt":"2023-11-02T09:59:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"rust/sdk: make exporting symbols opt-out\n\nWithout it, there are linker errors when both a driver crate\n(e.g. libsql-client-rs) and a user app have spin-sdk as their\ndependency. That's because both contain global symbols (T in nm output)\nand the linker is not able to determine which one is to stay.\n\nBefore the patch:\n```\n[sarna@sarna-pc rust]$ cargo build\n[sarna@sarna-pc rust]$ nm -a ../../target/debug/libspin_sdk.rlib | grep T\\ spin-sdk-\n0000000000000000 T spin-sdk-commit-8d4334eca6eb2b9cec0105612cc9a38402f839b4\n0000000000000000 T spin-sdk-language-rust\n0000000000000000 T spin-sdk-version-1-5\n```\n\nAfter:\n```\n[sarna@sarna-pc rust]$ cargo build --no-default-features -F http,json\n[sarna@sarna-pc rust]$ nm -a ../../target/debug/libspin_sdk.rlib | grep T\\ spin-sdk-\nnm: lib.rmeta: no symbols\n```","shortMessageHtmlLink":"rust/sdk: make exporting symbols opt-out"}},{"before":null,"after":"72b68825492727fa4711f57a9928b63bcb6829af","ref":"refs/heads/outputsymbols","pushedAt":"2023-11-02T09:45:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"rust/sdk: make exporting symbols opt-out\n\nWithout it, there are linker errors when both a driver crate\n(e.g. libsql-client-rs) and a user app have spin-sdk as their\ndependency. That's because both contain global symbols (T in nm output)\nand the linker is not able to determine which one is to stay.\n\nBefore the patch:\n```\n[sarna@sarna-pc rust]$ cargo build\n[sarna@sarna-pc rust]$ nm -a ../../target/debug/libspin_sdk.rlib | grep T\\ spin-sdk-\n0000000000000000 T spin-sdk-commit-8d4334eca6eb2b9cec0105612cc9a38402f839b4\n0000000000000000 T spin-sdk-language-rust\n0000000000000000 T spin-sdk-version-1-5\n```\n\nAfter:\n```\n[sarna@sarna-pc rust]$ cargo build --no-default-features\n[sarna@sarna-pc rust]$ nm -a ../../target/debug/libspin_sdk.rlib | grep T\\ spin-sdk-\nnm: lib.rmeta: no symbols\n```","shortMessageHtmlLink":"rust/sdk: make exporting symbols opt-out"}},{"before":"cb92986a7104a624ad0948243d47c4be3c6e4206","after":"2004b14515406d2c37b2583b71e5818581c2c069","ref":"refs/heads/spin-client-addr","pushedAt":"2023-03-17T05:14:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"http: add spin-client-addr header\n\nInspired by the outcome of #1297, this commit\nadds a `spin-client-addr` header, which exposes\nthe sender's IP address of a request to SDK users.\n\nSigned-off-by: Piotr Sarna <sarna@chiselstrike.com>","shortMessageHtmlLink":"http: add spin-client-addr header"}},{"before":null,"after":"cb92986a7104a624ad0948243d47c4be3c6e4206","ref":"refs/heads/spin-client-addr","pushedAt":"2023-03-16T20:01:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"http: add spin-client-addr header\n\nInspired by the outcome of #1297, this commit\nadds a `spin-client-addr` header, which exposes\nthe sender's IP address of a request to SDK users.\n\nSigned-off-by: Piotr Sarna <sarna@chiselstrike.com>","shortMessageHtmlLink":"http: add spin-client-addr header"}},{"before":"9df698ad484fe4c5f5ad7b6849f88ef3320684fd","after":"6fa9a7130b5200aad14fef184897326efd913a41","ref":"refs/heads/client-addr","pushedAt":"2023-03-16T19:30:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"abi-conformance: add client-addr field","shortMessageHtmlLink":"abi-conformance: add client-addr field"}},{"before":"c05e1c31fb077771748ba529d4d23ce073882697","after":"9df698ad484fe4c5f5ad7b6849f88ef3320684fd","ref":"refs/heads/client-addr","pushedAt":"2023-03-16T19:24:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"sdk: add client-addr field for HTTP request\n\nThe SDK is now aware that the request struct\nholds the sender's IP address as well.\nThe address is stored as Option<std::net::SocketAddr>\nand is kept in the request as an http::Request extension:\nhttps://docs.rs/http/0.2.9/http/struct.Extensions.html\n\nIt can be used in client code as follows:\n```rust\nfn handle_request(req: Request) -> Result<Response> {\n    println!(\"Sender address: {:?}\", req.extensions().get::<Option<std::net::SocketAddr>>());\n    (...)\n```\n\nSigned-off-by: Piotr Sarna <sarna@chiselstrike.com>","shortMessageHtmlLink":"sdk: add client-addr field for HTTP request"}},{"before":null,"after":"c05e1c31fb077771748ba529d4d23ce073882697","ref":"refs/heads/client-addr","pushedAt":"2023-03-16T19:17:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"psarna","name":"Piotr Sarna","path":"/psarna","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10433047?s=80&v=4"},"commit":{"message":"sdk: add client-addr field for HTTP request\n\nThe SDK is now aware that the request struct\nholds the sender's IP address as well.\nThe address is stored as Option<std::net::SocketAddr>\nand is kept in the request as an http::Request extension:\nhttps://docs.rs/http/0.2.9/http/struct.Extensions.html\n\nIt can be used in client code as follows:\n```rust\nfn handle_request(req: Request) -> Result<Response> {\n    println!(\"Sender address: {:?}\", req.extensions().get::<Option<std::net::SocketAddr>>());\n    (...)\n```","shortMessageHtmlLink":"sdk: add client-addr field for HTTP request"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADpbW2DgA","startCursor":null,"endCursor":null}},"title":"Activity · psarna/spin"}