questdb · bluestreak01 · Jul 15, 2024 · May 28, 2024 · May 28, 2024 · May 28, 2024
diff --git a/core/src/main/java/io/questdb/PropServerConfiguration.java b/core/src/main/java/io/questdb/PropServerConfiguration.java
@@ -68,6 +68,7 @@
 
 public class PropServerConfiguration implements ServerConfiguration {
 
+    public static final String ACL_ENABLED = "acl.enabled";
     public static final long COMMIT_INTERVAL_DEFAULT = 2000;
     public static final String CONFIG_DIRECTORY = "conf";
     public static final String DB_DIRECTORY = "db";
@@ -127,6 +128,7 @@ public class PropServerConfiguration implements ServerConfiguration {
     private final boolean defaultSymbolCacheFlag;
     private final int defaultSymbolCapacity;
     private final int detachedMkdirMode;
+    private final boolean devModeEnabled;
     private final boolean enableTestFactories;
     private final int fileOperationRetryCount;
     private final FilesFacade filesFacade;
@@ -240,6 +242,7 @@ public class PropServerConfiguration implements ServerConfiguration {
     private final PropPGWireDispatcherConfiguration propPGWireDispatcherConfiguration = new PropPGWireDispatcherConfiguration();
     private final String publicDirectory;
     private final PublicPassthroughConfiguration publicPassthroughConfiguration = new PropPublicPassthroughConfiguration();
+    private final int queryCacheEventQueueCapacity;
     private final long queryTimeout;
     private final int readerPoolMaxSegments;
     private final int repeatMigrationFromVersion;
@@ -261,7 +264,6 @@ public class PropServerConfiguration implements ServerConfiguration {
     private final long sharedWorkerSleepThreshold;
     private final long sharedWorkerSleepTimeout;
     private final long sharedWorkerYieldThreshold;
-    private final boolean simulateCrashEnabled;
     private final String snapshotInstanceId;
     private final boolean snapshotRecoveryEnabled;
     private final String snapshotRoot;
@@ -516,7 +518,6 @@ public class PropServerConfiguration implements ServerConfiguration {
     private long pgWorkerNapThreshold;
     private long pgWorkerSleepThreshold;
     private long pgWorkerYieldThreshold;
-    private final int queryCacheEventQueueCapacity;
     private boolean stringToCharCastAllowed;
     private long symbolCacheWaitUsBeforeReload;
 
@@ -653,7 +654,7 @@ public PropServerConfiguration(
 
         this.snapshotInstanceId = getString(properties, env, PropertyKey.CAIRO_SNAPSHOT_INSTANCE_ID, "");
         this.snapshotRecoveryEnabled = getBoolean(properties, env, PropertyKey.CAIRO_SNAPSHOT_RECOVERY_ENABLED, true);
-        this.simulateCrashEnabled = getBoolean(properties, env, PropertyKey.CAIRO_SIMULATE_CRASH_ENABLED, false);
+        this.devModeEnabled = getBoolean(properties, env, PropertyKey.DEV_MODE_ENABLED, false);
 
         int cpuAvailable = Runtime.getRuntime().availableProcessors();
         int cpuUsed = 0;
@@ -2494,11 +2495,6 @@ public long getSequencerCheckInterval() {
             return sequencerCheckInterval;
         }
 
-        @Override
-        public boolean getSimulateCrashEnabled() {
-            return simulateCrashEnabled;
-        }
-
         @Override
         public @NotNull CharSequence getSnapshotInstanceId() {
             return snapshotInstanceId;
@@ -2978,6 +2974,11 @@ public int getWriterTickRowsCountMod() {
             return writerTickRowsCountMod;
         }
 
+        @Override
+        public boolean isDevModeEnabled() {
+            return devModeEnabled;
+        }
+
         @Override
         public boolean isGroupByPresizeEnabled() {
             return cairoGroupByPresizeEnabled;
@@ -3061,7 +3062,7 @@ public boolean mangleTableDirNames() {
         public void populateSettings(CharSequenceObjHashMap<CharSequence> settings) {
             settings.put(RELEASE_TYPE, str(getReleaseType()));
             settings.put(RELEASE_VERSION, str(getBuildInformation().getSwVersion()));
-            settings.put("acl.enabled", Boolean.toString(!Chars.empty(httpUsername)));
+            settings.put(ACL_ENABLED, Boolean.toString(!Chars.empty(httpUsername)));
         }
     }
 

diff --git a/core/src/main/java/io/questdb/PropertyKey.java b/core/src/main/java/io/questdb/PropertyKey.java
@@ -432,7 +432,7 @@ public enum PropertyKey implements ConfigPropertyKey {
     CAIRO_MAX_FILE_NAME_LENGTH("cairo.max.file.name.length"),
     LINE_AUTO_CREATE_NEW_COLUMNS("line.auto.create.new.columns"),
     LINE_AUTO_CREATE_NEW_TABLES("line.auto.create.new.tables"),
-    CAIRO_SIMULATE_CRASH_ENABLED("cairo.enable.crash.simulation"),
+    DEV_MODE_ENABLED("dev.mode.enabled"),
     CAIRO_WAL_ENABLED_DEFAULT("cairo.wal.enabled.default"),
     CAIRO_WAL_PURGE_INTERVAL("cairo.wal.purge.interval"),
     CAIRO_WAL_SEGMENT_ROLLOVER_ROW_COUNT("cairo.wal.segment.rollover.row.count"),

diff --git a/core/src/main/java/io/questdb/cairo/CairoConfiguration.java b/core/src/main/java/io/questdb/cairo/CairoConfiguration.java
@@ -343,8 +343,6 @@ default RostiAllocFacade getRostiAllocFacade() {
 
     long getSequencerCheckInterval();
 
-    boolean getSimulateCrashEnabled();
-
     /**
      * Returns database instance id. The instance id is used by the snapshot recovery mechanism:
      * on database start the id is compared with the id stored in a snapshot, if any. If the ids
@@ -570,6 +568,8 @@ default int getWalPurgeWaitBeforeDelete() {
 
     int getWriterTickRowsCountMod();
 
+    boolean isDevModeEnabled();
+
     boolean isGroupByPresizeEnabled();
 
     boolean isIOURingEnabled();

diff --git a/core/src/main/java/io/questdb/cairo/CairoConfigurationWrapper.java b/core/src/main/java/io/questdb/cairo/CairoConfigurationWrapper.java
@@ -570,11 +570,6 @@ public long getSequencerCheckInterval() {
         return getDelegate().getSequencerCheckInterval();
     }
 
-    @Override
-    public boolean getSimulateCrashEnabled() {
-        return getDelegate().getSimulateCrashEnabled();
-    }
-
     @Override
     public @NotNull CharSequence getSnapshotInstanceId() {
         return getDelegate().getSnapshotInstanceId();
@@ -1055,6 +1050,11 @@ public int getWriterTickRowsCountMod() {
         return getDelegate().getWriterTickRowsCountMod();
     }
 
+    @Override
+    public boolean isDevModeEnabled() {
+        return getDelegate().isDevModeEnabled();
+    }
+
     @Override
     public boolean isGroupByPresizeEnabled() {
         return getDelegate().isGroupByPresizeEnabled();

diff --git a/core/src/main/java/io/questdb/cairo/CairoException.java b/core/src/main/java/io/questdb/cairo/CairoException.java
@@ -44,7 +44,7 @@ public class CairoException extends RuntimeException implements Sinkable, Flywei
     public static final int METADATA_VALIDATION = -100;
     public static final int ILLEGAL_OPERATION = METADATA_VALIDATION - 1;
     private static final int TABLE_DROPPED = ILLEGAL_OPERATION - 1;
-    public static final int METADATA_VALIDATION_RECOVERABLE = METADATA_VALIDATION - 1;
+    public static final int METADATA_VALIDATION_RECOVERABLE = TABLE_DROPPED - 1;
     public static final int PARTITION_MANIPULATION_RECOVERABLE = METADATA_VALIDATION_RECOVERABLE - 1;
     public static final int NON_CRITICAL = -1;
     private static final StackTraceElement[] EMPTY_STACK_TRACE = {};

diff --git a/core/src/main/java/io/questdb/cairo/DefaultCairoConfiguration.java b/core/src/main/java/io/questdb/cairo/DefaultCairoConfiguration.java
@@ -569,11 +569,6 @@ public long getSequencerCheckInterval() {
         return 10_000;
     }
 
-    @Override
-    public boolean getSimulateCrashEnabled() {
-        return false;
-    }
-
     @Override
     public @NotNull CharSequence getSnapshotInstanceId() {
         return "";
@@ -1055,6 +1050,11 @@ public int getWriterTickRowsCountMod() {
         return 1024 - 1;
     }
 
+    @Override
+    public boolean isDevModeEnabled() {
+        return false;
+    }
+
     @Override
     public boolean isGroupByPresizeEnabled() {
         return true;

diff --git a/core/src/main/java/io/questdb/cairo/ErrorTag.java b/core/src/main/java/io/questdb/cairo/ErrorTag.java
@@ -0,0 +1,73 @@
+package io.questdb.cairo;
+
+import io.questdb.std.Chars;
+import io.questdb.std.Os;
+import org.jetbrains.annotations.NotNull;
+
+public enum ErrorTag {
+    NONE(""),
+    UNSUPPORTED_FILE_SYSTEM("UNSUPPORTED FILE SYSTEM"),
+    DISK_FULL("DISK FULL"),
+    TOO_MANY_OPEN_FILES("TOO MANY OPEN FILES"),
+    OUT_OF_MMAP_AREAS("OUT OF MMAP AREAS"),
+    OUT_OF_MEMORY("OUT OF MEMORY");
+
+    private final String text;
+
+    ErrorTag(String text) {
+        this.text = text;
+    }
+
+    public static ErrorTag resolveTag(@NotNull CharSequence text) {
+        if (Chars.equals(text, UNSUPPORTED_FILE_SYSTEM.text)) {
+            return UNSUPPORTED_FILE_SYSTEM;
+        } else if (Chars.equals(text, DISK_FULL.text)) {
+            return DISK_FULL;
+        } else if (Chars.equals(text, TOO_MANY_OPEN_FILES.text)) {
+            return TOO_MANY_OPEN_FILES;
+        } else if (Chars.equals(text, OUT_OF_MMAP_AREAS.text)) {
+            return OUT_OF_MMAP_AREAS;
+        } else if (Chars.equals(text, OUT_OF_MEMORY.text)) {
+            return OUT_OF_MEMORY;
+        } else if (Chars.equals(text, NONE.text)) {
+            return NONE;
+        } else {
+            throw CairoException.nonCritical().put("Invalid WAL error tag [").put(text).put("]");
+        }
+    }
+
+    public static ErrorTag resolveTag(int code) {
+        return Os.isWindows() ? windows(code) : linux(code);
+    }
+
+    public String text() {
+        return text;
+    }
+
+    static ErrorTag linux(int code) {
+        switch (code) {
+            case 28:
+                return DISK_FULL;
+            case 24:
+                return TOO_MANY_OPEN_FILES;
+            case 12:
+                return OUT_OF_MMAP_AREAS;
+            default:
+                return NONE;
+        }
+    }
+
+    static ErrorTag windows(int code) {
+        switch (code) {
+            case 39:
+            case 112:
+                return DISK_FULL;
+            case 4:
+                return TOO_MANY_OPEN_FILES;
+            case 8:
+                return OUT_OF_MMAP_AREAS;
+            default:
+                return NONE;
+        }
+    }
+}
diff --git a/core/src/main/java/io/questdb/cairo/security/ReadOnlySecurityContext.java b/core/src/main/java/io/questdb/cairo/security/ReadOnlySecurityContext.java
@@ -56,7 +56,7 @@ public void authorizeAlterTableAddIndex(TableToken tableToken, @NotNull ObjList<
     public void authorizeAlterTableAlterColumnCache(TableToken tableToken, @NotNull ObjList<CharSequence> columnNames) {
         throw CairoException.authorization().put("Write permission denied").setCacheable(true);
     }
-    
+
     @Override
     public void authorizeAlterTableAlterColumnType(TableToken tableToken, @NotNull ObjList<CharSequence> columnNames) {
         throw CairoException.authorization().put("Write permission denied").setCacheable(true);