[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebView Js.nullable instead of option #151

Closed
maarekj opened this issue Feb 26, 2018 · 4 comments
Closed

WebView Js.nullable instead of option #151

maarekj opened this issue Feb 26, 2018 · 4 comments

Comments

@maarekj
Copy link
Contributor
maarekj commented Feb 26, 2018

It seems to me that in WebView.rei, we should change option(t) to Js.nullable(t)

~onNavigationStateChange: {
  .
  "url": option(string),
  "title": option(string),
  "loading": option(bool),
  "canGoBack": option(bool),
  "canGoForward": option(bool)
} => unit

to

~onNavigationStateChange: {
  .
  "url": Js.nullable(string),
  "title": Js.nullable(string),
  "loading": Js.nullable(bool),
  "canGoBack": Js.nullable(bool),
  "canGoForward": Js.nullable(bool)
} => unit

Indeed no conversion is done in WebView.re
@maarekj maarekj mentioned this issue Feb 26, 2018
Closed
@grabbou
Copy link
Collaborator
grabbou commented Sep 19, 2018

FYI: WebView is going to be removed from React Native soon anyway (already being extracted).

@maarekj
Copy link
Contributor Author
maarekj commented Sep 20, 2018

@grabbou 😲What will WebView be replaced by?

@grabbou
Copy link
Collaborator
grabbou commented Sep 20, 2018

Nothing :) It's going to be in a separate package as we are working on making the core even smaller. You can follow updates here: react-native-community/discussions-and-proposals#3

@ulrikstrid ulrikstrid mentioned this issue Sep 27, 2018
Closed
@MoOx
Copy link
Member
MoOx commented Apr 13, 2019

WebView as ben removed & won't be in the upcoming rewrite.

@MoOx MoOx closed this as completed Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MoOx @maarekj @grabbou