[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird address bar behavior when hostname is not a full url but internal servername #30

Closed
MarkNijhof opened this issue Jun 20, 2017 · 4 comments
Closed

Weird address bar behavior when hostname is not a full url but internal servername #30

MarkNijhof opened this issue Jun 20, 2017 · 4 comments

Comments

@MarkNijhof
Copy link

Hi,

We are using your router for a project that uses a server hostname vs a "domain name" and when doing so the address bar starts adding the servername to the url. http://bgowebvrs01/

address

The first is not loaded, but when hitting enter it immediately ads the hostname, and then after every navigation it ads a new one. The routing works btw I see the expected content.

When I use a full qualified name like http://bgowebvrs01.verit.kgjs.com/ none of this is happening. Also not when developing locally using http://localhost;3000/

-Mark
@MarkNijhof
Copy link
Author

Btw this is in Chrome and IE and I am using 3.0.1 of the route-url library

@robashton
Copy link
robashton commented Jul 19, 2017 •
edited

@MarkNijhof This isn't to do with this library, but instead sporto/erl which is a dependency of this.

The parsing of earlier versions of the library (10 in this case) is absolutely nonsensical, and has been patched in future versions to be (still absolutely nonsensical) slightly more correct.

The version of sporto/erl in elm-route-url needs updating, I gave it a crack this morning with @philipstears but because the Builder uses a Dict String String and newer versions of sporto/erl use a List String String it involves a breaking change across the library and is a PITA to implement as a casual outsider.

@rgrempel Something to be done here?

@robashton robashton mentioned this issue Jul 19, 2017
Closed
@rgrempel
Copy link
Owner

Sorry not to get to this sooner. I'm now working on #31 to update the sporto/erl dependency ... hopefully that will take care of it.

@rgrempel
Copy link
Owner

I've now published version 4, which will use more recent versions of sporto/erl. Let me know if that helps with this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgrempel @MarkNijhof @robashton