[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JoinType for physical operators #563

Open
danepitkin opened this issue Oct 13, 2023 · 0 comments · May be fixed by #572
Open

Refactor JoinType for physical operators #563

danepitkin opened this issue Oct 13, 2023 · 0 comments · May be fixed by #572

Comments

@danepitkin
Copy link
Contributor
danepitkin commented Oct 13, 2023 •
edited
Loading

HashJoin, MergeJoin, and NestedLoopJoin all duplicate the JoinType:

  enum JoinType {
    JOIN_TYPE_UNSPECIFIED = 0;
    JOIN_TYPE_INNER = 1;
    JOIN_TYPE_OUTER = 2;
    JOIN_TYPE_LEFT = 3;
    JOIN_TYPE_RIGHT = 4;
    JOIN_TYPE_LEFT_SEMI = 5;
    JOIN_TYPE_RIGHT_SEMI = 6;
    JOIN_TYPE_LEFT_ANTI = 7;
    JOIN_TYPE_RIGHT_ANTI = 8;
  }

Let's create a shared JoinType for physical operators.

Let's also change left/right anti-joins to specify NULL handling e.g. JOIN_TYPE_RIGHT_ANTI_WITH_NULL and JOIN_TYPE_RIGHT_ANTI_WITHOUT_NULL. See this discussion for more detail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add PhysicalJoinType danepitkin/substrait
1 participant
@danepitkin